stamp.fromISOString returns a time that is 10 minutes earlier than the supplied string

[aedgar93]

I will supply a string to the function and the resulting date will be 10 minutes earlier. For example, I will submit ISO formatted string with the time of 10:30 and the resulting time will be at 10:20

[bill]

That's odd, but all our tests are working. See ​https://github.com/dojo/dojo/blob/master/tests/date/stamp.js. Can you attach a test case that fails?

[aedgar93]

I have a function that looks like this:

function(isoDateString, format) {
		console.log(isoDateString);
		var isoDateObject = stamp.fromISOString(isoDateString);
		console.log(isoDateObject);
}

The console then outputs: 2013-07-15T13:40:05-0600 Mon Jul 15 2013 13:30:05 GMT-0600 (Mountain Daylight Time)

As you can see the input time is 13:40 and the output is 13:30.

Thank you

[bill]

OK, but you can follow my instructions and an actual test case rather than a code snippet?

Please attach a test case using the "attach file" button. It should be a single HTML file that we can load in the browser (i.e. not PHP, JSP, etc.).

[dante]

I didn't submit a test case either, but wrote a more complete c/p'able version from the alleged input/output:

(function(){ 

    require(["dojo/date/stamp"], function(stamp){ 
       var isoDateObject = stamp.fromISOString("2013-07-15T13:40:05-0600");
       console.log(isoDateObject); // Mon Jul 15 2013 13:30:05 GMT-0400 (EDT)
    }) 

})(); 

I could attach an .html w/ an additional dojo.js included, but writing a proper test case would be fun because it is time/date based. and by fun I really mean pain.

[bill]

OK, that reproduces for me, seems to be a bug.

[dante]

Thought about how to unit test this without caring about localization. isoDateObject.getMinutes() (and UTCMinutes) both return 30 from the above string.

[dante]

added failing unit test

[scribles]

I ran across the same problem. There is an error in the regular expression that parses the date format

/^{(?:(\d{4})(?:-(\d{2})(?:-(\d{2}))?)?)?(?:T(\d{2}):(\d{2})(?::(\d{2})(.\d+)?)?((?:[+-](\d{2}):(\d{2}))|Z)?)?$/;}

The decimal point in the seconds fraction selection should be escaped so that it only selects decimal points instead of any character. The colon in the time zone selection should be optional so it can select -0400 instead of just -04:00.

This fixed the problem for me

/^{(?:(\d{4})(?:-(\d{2})(?:-(\d{2}))?)?)?(?:T(\d{2}):(\d{2})(?::(\d{2})(\.\d+)?)?((?:[+-](\d{2}):?(\d{2}))|Z)?)?$/;}

[scribles]

Regular expression patch #17315

[scribles]

I think this is the same issue as #17522

[bill]

#17522 is a duplicate of this ticket.

[bill]

#17522 has a patch and test case (albeit against DOH not Intern).

[dylan]

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.