Opened 6 years ago

Closed 4 years ago

#17314 closed defect (patchwelcome)

dojo/dnd/Mover won't release on IE10 if delay used

Reported by: Kris Zyp Owned by:
Priority: undecided Milestone: 1.13
Component: DnD Version: 1.9.1
Keywords: Cc:
Blocked By: Blocking:

Description

On IE10, if Moveable is used with a delay, the MSPointerMove event (instead of MSPointerDown) triggers the instantiation of the Mover, but this event's button property is -1, and Mover expects to use this property to verify the mouse up event later to stop dragging. This fails because the mouseButton property is set to -1 and this doesn't match the value in the later mouse up event. I would suggest removing any condition whatsoever in onMouseUp function in Mover; I don't see how restricting the mouse up to the same button that triggered the drag is all that much more ergonomic than allowing any mouse up to end drag. The latter seems just as reasonable to me. If we do that we could remove the mouseButton property altogether.

Change History (2)

comment:1 Changed 6 years ago by bill

The code you are talking about was added in 198ea8e4c16c44ac9571c0cfaff4e2287e6bbfa8 to fix #4140. I agree it's probably overkill.

comment:2 Changed 4 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: newclosed

Given that no one has shown interest in creating a patch in the past 2+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.