safeMixin fails if source contains reference to window in different domain

[jameyg]

safeMixin fails in Firefox if the source contains a reference to a window in a different domain. For example:

var a = {
   target : window.top
};
var b = declare.safeMixin({}, a);

will fail if 'top' is in a different domain. This is do to the isFunction type check trigging a cross-domain access issue (currently only in FF..tested FF21).

If safeMixin is indirectly used in declare(), then this is easily worked around (this "defect" may just to be a documentation of the workaround...):

declare(null, {
   target: null,
   constructor: function(kwargs) {
      this.target = kwargs.target || window.top;
   }
});

[dylan]

Will update documentation as time permits. Or if you have time before I do, a pull request against ​https://github.com/dojo/docs/blob/master/dojo/_base/declare.rst would be appreciated.

[dylan]

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.