#17291 closed defect (invalid)
_TimeTextBox missing support for dropDownDefaultValue
Reported by: | pykaso | Owned by: | pykaso |
---|---|---|---|
Priority: | undecided | Milestone: | tbd |
Component: | Dijit - Form | Version: | 1.9.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Since 1.9 is the usability of TimeTextBox? terrible :( One of the missing features is missing support for dropDownDefaultValue.
In 1.9: line 175: this._refDate = fromIso("T00:00:00");
In 1.8.5:
line 195: this._refDate = new Date(time - time % (clickableIncrementSeconds*1000));
Change History (4)
comment:1 Changed 8 years ago by
Owner: | set to pykaso |
---|---|
Status: | new → pending |
comment:2 Changed 8 years ago by
Resolution: | → invalid |
---|---|
Status: | pending → closed |
Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!
comment:3 Changed 6 years ago by
I think this bug should be re-opened. See http://stackoverflow.com/questions/32213100/why-is-dijit-timetextbox-not-centering-on-value-in-drop-down/32219671#32219671
The current selected value is correctly highlighted however the dropdown does not scroll to this value.
This is due to this.currentFocus
being ignored by _TimePicker.js
(see line 185. Something is saved in a var time
but it is never used)
comment:4 Changed 6 years ago by
OK sure. Except, instead of reopening this I filed a new ticket, #18683. Note that this ticket is talking about dropDownDefaultValue
, but it should also scroll to the current value (if there is a value in the <input>
.
The current value of the TimeTextBox? (if there is one) is highlighted in the drop down. For example. in test_TimeTextBox.html you'll see 5:45PM being highlighted.
The dropDownDefaultValue setting is for DateTextBox?, to control which month is displayed, but that concept is meaningless with TimeTextBox?.
What behavior were you expecting?
For reference, the code in _DateTimePicker.js that passes in the currently selected value is:
currentFocus is also passed in, but is ignored for the _TimePicker drop down.
The code in _TimePicker.js that assigns the dijitTimePickerItemSelected class is: