partial rebuild fails when inserting into StatefulArray

[Stefan Meyer]

WidgetList? listens to StatefulArray? changes via watchElements. Before that event is fired the new elements are inserted into the StatefulArray? as undefined values. Then the values are set in a stateful manner via set(index, value). This leads to a property value change event being fired. The WidgetList? will update the target prop in the child widget. This is where things go wrong. The WidgetList?'s new children are not inserted yet. Therefore the target of the current child widget at the index is updated.

Given a list of names like ["john", "will"]. Inserting a new name "Henry" at index 1 results first in an update of the second widget being bound to "Henry" instead of "will" and then a new widget is inserted at index 1. Effectivly the WidegtList? is now bound to ["john", "henry", "henry"] and the Stateful instances at index 1 and 2 are identical.

The problem can be resolved by not updating the elements in a stateful manner.

I created a pull request for this in edhcat/dojox_mvc Unfortunately I did not find a proper testcase for this in 1,9 so I reactivated one from 1.9.

[Akira Sudoh]

The original pull req to edchat/dojox_mvc is: ​https://github.com/edchat/dojox_mvc/pull/80

[Akira Sudoh]

Pull req to dojo/dojox available in: ​https://github.com/dojo/dojox/pull/39

[Ed Chatelain <ed.chatelain@…>]

In 67eec023aee8e042e8f1d9dcc7fd653ee70792a7/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Ed Chatelain <ed.chatelain@…>]

In cc357612faa5190a018af86a9bebc0eb605ebf8f/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?