[patch][cla] Enable looping over objects with {% for key, value in object %}

[hcampbell]

In the following example:

require([
    "dojo/dom-construct",
    "dojox/dtl/Context",
    "dojox/dtl/_base",
    "dojox/dtl/dom",
    "dojox/dtl/tag/logic"
    ],
    function(domConstruct, Context, dtl) {
        var templateString = "" +
                "<dl>" + 
                "    {% for k, v in obj %}" +
                "    <dt>{{ k }}</dt>" +
                "    <dd>{{ v }}</dd>" +
                "    {% endfor %}" +
                "</dl>",
            testObj = {
                "HTML": "HyperText Markup Language",
                "CSS": "Cascading Stylesheet"
            },
            template;
        
        template = new dtl.DomTemplate(templateString);
        template.render(new Context({"obj": testObj}));
        domConstruct.place(
            template.getRootNode(),
            document.body
        );
    }
);

The output is:

<dl>
       <dt>HyperText Markup Language</dt>
       <dd>undefined</dd>
       <dt>Cascading Stylesheet</dt>
       <dd>undefined</dd>
</dl>

ForNode? tests for objects and assigns values to the tag arguments. Ideally it would store both key and value, and zip to the supplied arguments, giving the expected result:

<dl>
       <dt>HTML</dt>
       <dd>HyperText Markup Language</dd>
       <dt>CSS</dt>
       <dd>Cascading Stylesheet</dd>
</dl>

The patch to fix the issue is very minor (see attached). This will, however, break existing templates that treats objects as array of values (ie discarding keys). This could be fixed by reversing the order of key/value pairs, but that would break compatibility with the Django template system.

Will reference pull request.

[hcampbell]

GH Pull request: ​https://github.com/dojo/dojox/pull/14

[dylan]

I'll land this for 1.11, and make a note in the release notes.

[dylans <[email protected]…>]

In 1dcf38ea5f15079355ac20df0b372753da9dd6bc/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?