#17239 closed defect (fixed)
[regression] dojox.layout.FloatingPane dock doesn't work in dojo1.9.0
| Reported by: | lachlan | Owned by: | dante |
|---|---|---|---|
| Priority: | low | Milestone: | 1.9.2 |
| Component: | DojoX Layout | Version: | 1.9.0 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
FloatingPane? dock doesn't work any more. The same code works perfectly in dojo1.8.3.
Tried dojo nightly test of test_floatingpane today (7th June, 2013), and it doesn't work either:
http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/layout/tests/test_FloatingPane.html
When I minimize the five dockable panes they just disappear.
Tried dojo 1.8 test of test_floatingpane, and it works:
When I minimize the same five dockable panes they docked at screen right and at the bottom.
First reported by, and report copied from, brightsea's mailing list post (which means it hasn't been working since at least 9th May, 2013):
Change History (7)
comment:1 Changed 8 years ago by
| Milestone: | tbd → 1.9.1 |
|---|---|
| Owner: | set to dylan |
| Status: | new → assigned |
| Summary: | dojox.layout.FloatingPane dock doesn't work in dojo1.9.0 → [regression] dojox.layout.FloatingPane dock doesn't work in dojo1.9.0 |
comment:2 Changed 8 years ago by
| Milestone: | 1.9.1 → 1.9.2 |
|---|
1.9.1 is released; moving all outstanding tickets to next milestone.
comment:3 Changed 8 years ago by
I found the problem:
In file Dock.js on line 18 a mistaken typing
templateString: '<div class="dojoxDock"><ul dojo-dojo-attach-point="containerNode" class="dojoxDockList"></ul></div>',
Solution:
templateString: '<div class="dojoxDock"><ul data-dojo-attach-point="containerNode" class="dojoxDockList"></ul></div>',
comment:5 Changed 8 years ago by
| Owner: | changed from dylan to dante |
|---|---|
| Priority: | undecided → low |
comment:6 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
FloatingPane? was completely broken in fa393559ad4452b69b2042d8011d32b137366a63 and somewhat repaired after that in bb1f9917ab5cac1bbe1b9e5a2718eeeebf20b9c5, but the docking never worked after the fa393559ad4452b69b2042d8011d32b137366a63 check in.