[regression] dijit.form.Select throws invalid argument error in IE8 and IE10

[bemorris]

The "invalid argument" error occurs when calling dijit.form.Select.removeOption. I debugged the code and I found the error occurs on the following line in _FormSelectWidget.getOptions:

if (!(a in option)

option[a] != valueOrIdx[a]) { == and not === so that 100 matches '100'

In IE8/10 the error happens because valueOrIndx contains "text", which is not found in the option element. I believe this line should be changed to the following:

if(!(a in option)

!(a in valueOrIdx)

option[a] != valueOrIdx[a])

[Douglas Hays]

worked in 1.7

[Douglas Hays]

User's option array was being populated via:

options.push(domConstruct.create("option", {
	value: timestamp,
	label: this._generateOptionLabel(message, ts)
}));

instead of

options.push(new Option(this._generateOptionLabel(message, ts), timestamp));

which makes IE happier.