Opened 7 years ago
Closed 6 years ago
#17229 closed defect (fixed)
dojox/mobile/Overlay: when used inside a ScrollableView, the Overlay can appear at a wrong location thus being invisible
| Reported by: | Adrian Vasiliu | Owned by: | Sebastien Brunot |
|---|---|---|---|
| Priority: | undecided | Milestone: | |
| Component: | DojoX Mobile | Version: | 1.9.0 |
| Keywords: | Cc: | Sebastien Brunot | |
| Blocked By: | Blocking: |
Description (last modified by )
When a dojox/mobile/Overlay is used inside a dojox/mobile/ScrollableView, showing the opener can make it appear at a wrong location, outside of the visible area.
How to reproduce:
- Open https://bugs.dojotoolkit.org/attachment/ticket/13865/test_Opener-scroll.html on Safari (iPhone or iPad)
- Scroll the view down to the field and tap it.
==> The opener is displayed above the field, not at the bottom of the screen but at the top of the page thus in an invisible area...
Issue initially reported by Sebastien Brunot in a comment of #13865. Since it is a distinct issue, I create a separate ticket for it.
Change History (12)
comment:1 Changed 7 years ago by
| Cc: | Sebastien Brunot added |
|---|---|
| Component: | General → DojoX Mobile |
| Milestone: | tbd → 1.9.1 |
| Owner: | set to Adrian Vasiliu |
| Status: | new → assigned |
comment:2 Changed 7 years ago by
comment:3 Changed 7 years ago by
| Milestone: | 1.9.1 → future |
|---|
Postponed to give us time for a saner solution (see the discussion in the PR).
comment:4 Changed 6 years ago by
The saner solution was brought by... iOS 7, where the controversial part of the PR is no longer necessary.
comment:5 Changed 6 years ago by
| Description: | modified (diff) |
|---|
comment:6 Changed 6 years ago by
| Summary: | dojox/mobile/Overlay: when used inside a ScrollableView, the Overlay can cover the field associated to it → dojox/mobile/Overlay: when used inside a ScrollableView, the Overlay can appear at a wrong location thus being invisible |
|---|
comment:7 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:9 Changed 6 years ago by
| Milestone: | future → 1.9.2 |
|---|
comment:10 Changed 6 years ago by
| Milestone: | 1.9.2 |
|---|---|
| Resolution: | fixed |
| Status: | closed → reopened |
Reproduced with safari browser on iOS 5 (ipad 1) with dojo 1.10 beta1.
Using the test page dojos/mobile/tests/test_Overlay.html:
- Click the popup button at the top: the overlay is correctly displayed
- Click the Done button of the overlay: it is correctly hidden
- Scroll to the bottom of the page and click the pop up button there: the overlay is not visible
- Scroll to the top of the page: the overlay is there, it opened at its first position instead of opening at the bottom of the page
comment:11 Changed 6 years ago by
| Owner: | changed from Adrian Vasiliu to Sebastien Brunot |
|---|---|
| Status: | reopened → assigned |
comment:12 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Since it affects an outdated ios version (5, while we are at 7.1 as of today), I don't want to take the rist the fix breaks on another platform. In case someone needs a workaround, a possible fix is available here: https://github.com/dojo/dojox/pull/105
sbrunot's PR: https://github.com/dojo/dojox/pull/12