#17217 closed defect (fixed)
[regression] Setting new store on Select is not removing old options
Reported by: | adros | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | undecided | Milestone: | 1.8.5 |
Component: | Dijit - Form | Version: | 1.8.4 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
When I set new store to dijit/form/Select, old options are not removed (same behaviour on dojox/form/CheckedMultiSelect).
I suppose that this bug appears because of this commit b43a64589.
removeOption: function(/*String|__SelectOption|Number|Array*/ valueOrIdx){ this.getOptions([].concat(valueOrIdx));
Argument valueOrIdx that is passed to this method is NodeList?. And concating [] with NodeList? will return [NodeList?].
I have attached test case, and also proposed patch.
Attachments (2)
Change History (12)
Changed 8 years ago by
Attachment: | patch.diff added |
---|
Changed 8 years ago by
Attachment: | _formSelectWidgetTest.html added |
---|
comment:1 Changed 8 years ago by
Milestone: | tbd → 1.9.1 |
---|---|
Owner: | set to Douglas Hays |
Status: | new → assigned |
Summary: | Setting new store on Select is not removing old options → [regression] Setting new store on Select is not removing old options |
comment:5 follow-up: 6 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:6 Changed 8 years ago by
Version: | 1.9.0 → 1.8.4 |
---|
Note: See
TracTickets for help on using
tickets.
Sounds like a regression, in which case it would ideally go into 1.9.1.