Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#17212 closed defect (fixed)

TreeMap drill up is broken

Reported by: stelian56 Owned by: cjolif
Priority: undecided Milestone: 1.10
Component: Dojox Version: 1.9.0
Keywords: Cc:
Blocked By: Blocking:

Description

Steps to reproduce:

  1. Open dojox/treemap/tests/test.html
  2. Select Group by: Mode then State
  3. Double click Water to drill down to level 2
  4. Double click CA to drill down to level 3
  5. Double click CA to drill up to level 2

The tree map jumps all the way to level 1 instead.

Suggested fix to dojox/treemap/TreeMap.js:

refreshRendering: function(){
...

var parentItem = null;
var rootItemRenderer = this._getRenderer(rootItem);
if (rootItemRenderer) {
    parentItem = rootItemRenderer.parentItem;
}
this._buildRenderer(this.domNode, parentItem, rootItem, {

...

Change History (6)

comment:1 Changed 7 years ago by bill

Component: GeneralDojox
Owner: set to cjolif
Status: newassigned

comment:2 Changed 7 years ago by cjolif

Thanks for reporting this.

I will commit a slightly different fix (but same spirit). For the future stelian56 please make sure to sign a Dojo CLA even for fixes contributions (maybe you have one but not listed as stelian56). See: http://dojofoundation.org/about/claCheck and now: https://github.com/dojo/dojox/blob/master/CONTRIBUTING.md for more details on how we expect contributions now that we moved to github.

comment:3 Changed 7 years ago by Christophe Jolif <cjolif@…>

Resolution: fixed
Status: assignedclosed

In 8be82a34bad4f0f4592a38367a1b90fec0ea4de4/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 7 years ago by stelian56

Christophe,

Thank you for fixing the bug.

I have just signed an individual CLA. However, I am reluctant to become a contributor. If you don't mind, I am going to suggest any future bug fixes via bug reports.

Stelian

comment:5 Changed 7 years ago by cjolif

Sure. No problem there is no obligation to contribute :)

comment:6 Changed 6 years ago by bill

Milestone: tbd1.10
Note: See TracTickets for help on using tickets.