Promise.always doesn't propagate errors

[jandockx]

Promise always doesn't propagate errors.

The current implementation is

always: function(callbackOrErrback){
			// summary:
			//		Add a callback to be invoked when the promise is resolved
			//		or rejected.
			// callbackOrErrback: Function?
			//		A function that is used both as a callback and errback.
			// returns: dojo/promise/Promise
			//		Returns a new promise for the result of the callback/errback.

			return this.then(callbackOrErrback, callbackOrErrback);
		}

It should be

 return this.then(
    callbackOrErrBack,
    function(err) {
        callbackOrErrBack.call();
        throw err;
    }
);

[ben hockey]

i'm fairly sure our implementation is intentionally like this. i'll leave it to mark to give further feedback or close the ticket.

[Mark Wubben]

Yes this is as intended. You shouldn't handle rejections separately from fulfillment in these callbacks, if you need that use then().

[bill]

Give ticket hopefully meaningful summary.

[jandockx]

got it; I though it was intended as a "finally"; maybe that could be a separate (new) function