Opened 6 years ago

Closed 6 years ago

#17210 closed defect (fixed)

Fieldset: toggleable=false styling wrong

Reported by: Samuel Ondrek Owned by: bill
Priority: undecided Milestone: 1.10
Component: Dijit Version: 1.9.0
Keywords: Cc:
Blocked By: Blocking:

Description

Hello,

You added toggleable fieldset, but you didn't add CSS for toggleable=false.

As you can see in my demo, toggleable=true looks like toggleable=false without my fix. http://jsfiddle.net/ondrek/aWCtW/

Please add this to CSS:

.dijitFieldsetTitleFixedOpen .dijitArrowNode {
	display: none;
}
	
.dijitFieldsetTitleFixedOpen .dijitFieldsetLegendNode {
	cursor: default;
}

Change History (5)

comment:1 Changed 6 years ago by bill

Milestone: tbd1.9.1
Owner: set to bill
Status: newassigned
Summary: Broken Closable FieldsetFieldset: toggleable=false doesn't work

Ah right, makes sense, OK, thanks.

comment:2 Changed 6 years ago by Samuel Ondrek

Fast response :) thanks.

comment:3 Changed 6 years ago by bill

Note that dijit.css already has CSS that's supposed to work, it's just that class names aren't matching up:

.dijitFixedOpen, .dijitFixedClosed {
	/* TitlePane that cannot be toggled */
	cursor: default;
}
.dijitFixedOpen .dijitArrowNode, .dijitFixedOpen .dijitArrowNodeInner,
.dijitFixedClosed .dijitArrowNode, .dijitFixedClosed .dijitArrowNodeInner{
	/* don't show the open close icon, it makes the user think the pane is closable*/
	display: none;
}

comment:4 Changed 6 years ago by bill

Milestone: 1.9.11.10
Summary: Fieldset: toggleable=false doesn't workFieldset: toggleable=false styling wrong

The changes are a bit more involved then I thought, in order to get high contrast mode to work too. I'll just check in for the 1.10/2.0 releases.

As a side note, I'm not sure why you are using this widget at all if you don't want to toggle.

comment:5 Changed 6 years ago by bill

Resolution: fixed
Status: assignedclosed

Fixed in 1a0c47d3a6da4167bc06d569f3bd9f292762623e.

Note: See TracTickets for help on using tickets.