Opened 7 years ago

Closed 4 years ago

#17203 closed defect (fixed)

dojox/widget/Toaster expects dojo/window object to support onscroll event

Reported by: joshuaboshi Owned by:
Priority: undecided Milestone: 1.11
Component: DojoX Widgets Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

During scrolling, dojox/widget/Toaster had the functionality to stay at fixed position by connection (dojo/_base/connect) to dojo/window onscroll event.

I don't know since what version is the onscroll event of dojo/window missing. But when user scrolls in window (dojo 1.8), the toaster is moving too.

In my project, I fixed it by removing dojo/window and connecting directly to bare window object. But I am sure, that this is not acceptable solution and needs to be fixed in better way.

Attachments (1)

dojo toaster.html (1.1 KB) - added by gbranchaud 6 years ago.
Simple test case that shows a toaster that does not stay at the bottom of the page (dojo 1.9.0)

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by gbranchaud

Attachment: dojo toaster.html added

Simple test case that shows a toaster that does not stay at the bottom of the page (dojo 1.9.0)

comment:1 Changed 6 years ago by gbranchaud

We hit the same issue (on dojo v1.8.3). We fixed it pretty much the same way as the original author of this bug.

I attached a simple test case that shows the problematic behavior. The test case uses dojo 1.9.0 (from google cdn).

Steps to repro:

  1. open the dojo toaster.html in a browser
  2. Scroll the page.

Expected results:

  1. The toaster stays at the bottom of the viewport while you scroll.

Actual results:

  1. The toaster moves up and rapidly disappears from the viewport while you scroll.

comment:2 Changed 4 years ago by dylan

Milestone: tbd1.11
Resolution: fixed
Status: newclosed

I believe this was also fixed by the Toaster clean-up in https://bugs.dojotoolkit.org/changeset/56ee55d6b240de0b921f4ec200bd3e08951cbdcc/dojox

Note: See TracTickets for help on using tickets.