Changes between Initial Version and Version 1 of Ticket #17192, comment 19


Ignore:
Timestamp:
Jul 13, 2013, 12:09:46 AM (7 years ago)
Author:
bill
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17192, comment 19

    initial v1  
    1 So I'd advise you to recreate the repository where dojo, dijit, and dojox are submodules.   Or if you need to modify the files in those directories, then at least check in the pointer code as a separate commit.
     1So I'd advise you to recreate the repository where dojo, dijit, and dojox are submodules.   Or if you need to modify the files in those directories, then recreate the repository, first committing those existing files, and then checking in the pointer code as a separate commit.
    22
    33Anyway, I have lots of little comments about the code, but the main one is that you seem to be missing all the target related code for touchmove.    As the user moves his finger from one node to another, it should generate pointerover and pointerout events.   In addition the app needs to be able to setup pointerenter and pointerleave events.   And finally, while touchmove's target is always the node that was originally touched (i.e. the touchstart node), the pointermove target (IIUC) is the node that the mouse is currently over, and the relatedTarget is the node that the mouse was previously over.