Opened 6 years ago
Closed 6 years ago
#17184 closed defect (fixed)
[regression] dojox/widget/Portlet broken in Dojo 1.9
| Reported by: | achopra | Owned by: | cjolif |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.8.5 |
| Component: | DojoX Widgets | Version: | 1.8.0 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
dojox/widget/Portlet is broken in Dojo 1.9 because it depends on dojo.style which has been deprecated. dom-style must be used instead.
The bug is found at lines 54, 141, 166, 215, 242, 243 & 336 in the Portlet.js.uncompressed.js file.
I would thing the fix would be to simple import/require dom-style
and change dojo.style(...) to domStyle.set(...)
Change History (9)
comment:1 Changed 6 years ago by
| Owner: | set to achopra |
|---|---|
| Status: | new → pending |
comment:2 Changed 6 years ago by
| Status: | pending → new |
|---|
I am using the Dojo 1.9.0 release build tarball.
When trying to create a simple portlet programatically, I get 'dojo.style is not a function'
and I get the following in the firebug console.
>>> dojo.style undefined
The example on the nightly build site works! It is possible that the issue is already fixed but the release tarball does not have the fix yet. I will try the nightly build.
comment:3 Changed 6 years ago by
| Milestone: | tbd → 1.8.5 |
|---|---|
| Owner: | changed from achopra to cjolif |
| Status: | new → assigned |
| Summary: | dojox/widget/Portlet broken in Dojo 1.9 → [regression] dojox/widget/Portlet broken in Dojo 1.9 |
| Version: | 1.9.0 → 1.8.0 |
OK, right, a regression from #15517.
comment:4 Changed 6 years ago by
refs #17184. Fixes the regression by making sure the AMD port is correct.
Changeset: 825f337fc0826bc1825a1a2894df57a3c4233391
comment:5 Changed 6 years ago by
comment:6 Changed 6 years ago by
refs #17184. Fixes the regression by making sure the AMD port is correct.
Changeset: d1e488d431418ab43f8886c395d7872ca09d59cc
comment:7 Changed 6 years ago by
comment:8 Changed 6 years ago by
refs #17184. Fixes the regression by making sure the AMD port is correct.
Changeset: b8202790de036a4e7da245d6f4a3ecccf4da70a2
comment:9 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
It seems like you're confused about what "deprecated" means. The test_Portlet.html test case is working fine for me, can you provide a test case that shows a failure?