#17178 closed defect (fixed)
[patch][cla]dojox GFX text measuring function can bleed onto screen.
| Reported by: | Jared Jurkiewicz | Owned by: | Eric Durocher |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.10 |
| Component: | DojoX GFX | Version: | 1.8.3 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
In dojox/gfx/_base.js there is a text measuring function:
_getTextBox
This function inserts a node at -10000, and uses it to calculate width. The problem is that if the content is long, it can bleed onto the screen (longer than 10000px). There is a simple fix for this; set the visibility to hidden, and at the end of the function, empty the node. If you empty it, it also makes it a bit more performant in that it reduces the # of nodes on the page.
Patch forthcoming
Attachments (1)
Change History (5)
Changed 6 years ago by
| Attachment: | 17178.patch added |
|---|
comment:1 Changed 6 years ago by
| Summary: | dojox GFX text measuring function can bleed onto screen. → [patch][cla]dojox GFX text measuring function can bleed onto screen. |
|---|
comment:2 Changed 5 years ago by
| Owner: | set to Eric Durocher |
|---|---|
| Status: | new → assigned |
comment:3 Changed 5 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixed by GIT commit: https://github.com/dojo/dojox/commit/12774a98c709acd65bd85e09d8beb7ea40e04d2d
comment:4 Changed 5 years ago by
| Milestone: | tbd → 1.10 |
|---|
Note: See
TracTickets for help on using
tickets.
Patch for _getTextBox