Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#17178 closed defect (fixed)

[patch][cla]dojox GFX text measuring function can bleed onto screen.

Reported by: Jared Jurkiewicz Owned by: Eric Durocher
Priority: undecided Milestone: 1.10
Component: DojoX GFX Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

In dojox/gfx/_base.js there is a text measuring function:

_getTextBox

This function inserts a node at -10000, and uses it to calculate width. The problem is that if the content is long, it can bleed onto the screen (longer than 10000px). There is a simple fix for this; set the visibility to hidden, and at the end of the function, empty the node. If you empty it, it also makes it a bit more performant in that it reduces the # of nodes on the page.

Patch forthcoming

Attachments (1)

17178.patch (962 bytes) - added by Jared Jurkiewicz 6 years ago.
Patch for _getTextBox

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Jared Jurkiewicz

Attachment: 17178.patch added

Patch for _getTextBox

comment:1 Changed 6 years ago by Jared Jurkiewicz

Summary: dojox GFX text measuring function can bleed onto screen.[patch][cla]dojox GFX text measuring function can bleed onto screen.

comment:2 Changed 5 years ago by Eric Durocher

Owner: set to Eric Durocher
Status: newassigned

comment:3 Changed 5 years ago by Eric Durocher

Resolution: fixed
Status: assignedclosed

comment:4 Changed 5 years ago by bill

Milestone: tbd1.10
Note: See TracTickets for help on using tickets.