Opened 6 years ago

Closed 4 years ago

#17169 closed defect (patchwelcome)

[dojox/app] Adding top-level nls file breaks build system

Reported by: Paul Christopher Owned by: Ed Chatelain
Priority: undecided Milestone: 1.13
Component: DojoX App Version: 1.9.0
Keywords: Cc:
Blocked By: Blocking:

Description

Description

See attached extra files for the existing test case dojox/app/test/multiSceneApp: Adding translations for the tab bar in application.html seems to break the build system:

discovering resources...
starting reading resources...
starting processing raw resource content...
starting tokenizing resource...
starting processing resource tokens...
starting parsing resource...
js: "<eval'ed string>#1(Function)#1(eval)", line 96: uncaught JavaScript runtime
 exception: ReferenceError: "params" is not defined.
        at <eval'ed string>#1(Function)#1(eval):96
        at <eval'ed string>#1(Function)#1(eval):277
        at <eval'ed string>#1(Function)#1(eval):277
        at <eval'ed string>#1(Function)#1(eval):248 (doBuild)
        at <eval'ed string>#1(Function)#1(eval):283
        at <eval'ed string>#1(Function)#1(eval):83

I.e. the unbuilt version with translations just works fine, but as soon as you try to build the application, the build fails with the error message shown above.

Steps to reproduce the issue

  • Add/ replace the files in folder dojox/app/tests/multiSceneApp with the files provided in the attached zip archive.
  • Run index.html: Translations should be fine.
  • Now try to build the application. This fails with the above error message.

Discussion

I ran into this issue with my own multiSceneApp like application. The build gets broken when adding general, top-level translations for the tab bar. I could now reproduce the issue with dojox/app/tests/multiSceneApp. There might be still other issues with building dojox/app/tests/multiSceneApp (such as the build tool does not like the location folder "test"), but this is not the aim of this ticket.

Attachments (1)

mutliSceneApp.zip (4.9 KB) - added by Paul Christopher 6 years ago.

Download all attachments as: .zip

Change History (2)

Changed 6 years ago by Paul Christopher

Attachment: mutliSceneApp.zip added

comment:1 Changed 4 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: newclosed

Given the lack of attention to this ticket, we would accept a pull request. Closing as patchwelcome.

Note: See TracTickets for help on using tickets.