#1715 closed defect (fixed)
TreeWithNode breaks while eagerWidgetInstantiation is true
Reported by: | ak30 (at) hotmail.com | Owned by: | ilia |
---|---|---|---|
Priority: | high | Milestone: | |
Component: | Widgets | Version: | 0.3 |
Keywords: | TreeWithNode | Cc: | |
Blocked By: | Blocking: |
Description
When TreeWithNode? has set eagerWidgetInstantiation to true, and RPC server sends nodes with children, then treeV3 widget crashes. It is caused in TreeWithNode?.js here: ====== if (this.tree.eagerWidgetInstantiation) { dojo.lang.forEach(this.children, function(child) { dojo.debug("tree.eagerWidgetInstantiation for "+child)
child.setChildren();
dojo.debug("SUCCESFULL tree.eagerWidgetInstantiation for "+child) }); } ====== a loop should be removed, since it is called on not initialised child widgets.
FIXED (working for me) VERSION =====
if (this.tree.eagerWidgetInstantiation) {
child.isFolder | (child.isFolder==null)) |
child.setChildren(); }
Change History (6)
comment:1 Changed 14 years ago by
Milestone: | → 0.4.1 |
---|---|
Owner: | changed from bill to ilia |
comment:2 Changed 14 years ago by
Milestone: | 0.4.1 → 0.5 |
---|
comment:3 Changed 14 years ago by
Milestone: | 0.5 → 0.4.1 |
---|
comment:4 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
My patch was bit different, but fixed in rev. 6551
comment:5 Changed 14 years ago by
Thanks ilia for the fix, works great (and I've learned that don't need to set isFolder in RPC ;-)
Since Alex decided that TreeV3 shouldn't be marked experimental, except for the DnD part, we need to do this for 0.4.1.