Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1715 closed defect (fixed)

TreeWithNode breaks while eagerWidgetInstantiation is true

Reported by: ak30 (at) hotmail.com Owned by: ilia
Priority: high Milestone:
Component: Widgets Version: 0.3
Keywords: TreeWithNode Cc:
Blocked By: Blocking:

Description

When TreeWithNode? has set eagerWidgetInstantiation to true, and RPC server sends nodes with children, then treeV3 widget crashes. It is caused in TreeWithNode?.js here: ====== if (this.tree.eagerWidgetInstantiation) { dojo.lang.forEach(this.children, function(child) { dojo.debug("tree.eagerWidgetInstantiation for "+child)

child.setChildren();

dojo.debug("SUCCESFULL tree.eagerWidgetInstantiation for "+child) }); } ====== a loop should be removed, since it is called on not initialised child widgets.

FIXED (working for me) VERSION =====

if (this.tree.eagerWidgetInstantiation) {

if(child.children.length
child.isFolder (child.isFolder==null))

child.setChildren(); }

Change History (6)

comment:1 Changed 13 years ago by bill

Milestone: 0.4.1
Owner: changed from bill to ilia

comment:2 Changed 13 years ago by bill

Milestone: 0.4.10.5

comment:3 Changed 13 years ago by bill

Milestone: 0.50.4.1

Since Alex decided that TreeV3 shouldn't be marked experimental, except for the DnD part, we need to do this for 0.4.1.

comment:4 Changed 13 years ago by ilia

Resolution: fixed
Status: newclosed

My patch was bit different, but fixed in rev. 6551

comment:5 Changed 13 years ago by ak30 at hotmail.com

Thanks ilia for the fix, works great (and I've learned that don't need to set isFolder in RPC ;-)

comment:6 Changed 12 years ago by (none)

Milestone: 0.4.1

Milestone 0.4.1 deleted

Note: See TracTickets for help on using tickets.