Opened 5 years ago

Last modified 2 years ago

#17144 new enhancement

The build system does not resolve an amd plugin used directly as a layer dependency.

Reported by: Patrick Ruzand Owned by: Rawld Gill
Priority: high Milestone: 1.15
Component: BuildSystem Version: 1.9.0
Keywords: Cc: cjolif, Clement Mathieu, dg
Blocked By: Blocking:

Description

With such a build profile:

var profile = {
  layers:{
    "myapp/src":{
      include:[
        "dojo/text!myapp/foo.html"
      ]
    }
  }
};

the build engine reports a "Missing include module for layer." error for the module "dojo/text!myapp/foo.html" and the file is not included in the layer.

It should be possible to include an amd plugin as a layer dependency in the layer definition.

Change History (11)

comment:1 Changed 5 years ago by cjolif

This would be really useful for tools that build their own profile from another input source. That is the case for example of dojox/app build tool. Not being able to do that prevents us from building a template into a layer when that template is listed in the dojox/app JSON configuration file.

comment:2 Changed 5 years ago by cjolif

Cc: cjolif added

comment:3 Changed 5 years ago by cjolif

Priority: undecidedhigh

comment:4 Changed 5 years ago by cjolif

Cc: Clement Mathieu added

comment:5 Changed 5 years ago by cjolif

Cc: dg added

comment:6 Changed 5 years ago by dg

+1, I have the same problem on my application layer.

comment:7 Changed 5 years ago by poffdeluxe

+1, would be very helpful in building my dojox/app application

comment:8 Changed 5 years ago by poffdeluxe

Any new changes with this?

comment:9 Changed 5 years ago by Clement Mathieu

If you do something like this, it should work. (I tested it using node to run the build system and dojo 1.9.1)

var profile = {
  layers:{
    "myapp/src":{
      include:[
        "myapp/foo.html"
      ]
    }
  }
};

comment:10 Changed 3 years ago by dylan

Milestone: tbd1.12

comment:11 Changed 2 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.