Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#17138 closed defect (fixed)

[regression] Request module no longer compatible with Node.js

Reported by: ZeroFactor Owned by: Kitson Kelly
Priority: blocker Milestone: 1.9.1
Component: IO Version: 1.9.0
Keywords: Cc: Kitson Kelly
Blocked By: Blocking:

Description (last modified by bill)

A regression seems to have been introduced in [31326] in the change to handlers.js.

Line 6 requires a module that tries to write html to the dom (which doesn't exist in Node):

'../selector/_loader' // only included for has() qsa tests

Change History (10)

comment:1 Changed 7 years ago by bill

Component: GeneralIO
Milestone: tbd1.9.1
Owner: set to Bryan Forbes
Summary: Request module no longer compatible with Node.js[regression] Request module no longer compatible with Node.js

comment:2 Changed 7 years ago by Kitson Kelly

Cc: Kitson Kelly added

comment:3 Changed 7 years ago by bill

Description: modified (diff)

comment:4 Changed 7 years ago by Kitson Kelly

It is commit 54b0bc1 in GitHub? now.

comment:5 Changed 7 years ago by Colin Snover

Priority: undecidedblocker

comment:6 Changed 7 years ago by Colin Snover

Status: newassigned

comment:7 Changed 7 years ago by Kitson Kelly

Owner: changed from Bryan Forbes to Kitson Kelly

comment:8 Changed 7 years ago by Kitson Kelly <dojo@…>

Resolution: fixed
Status: assignedclosed

In f8c0a982ec0ba4debb21713a27732fcfafb527f1/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:9 Changed 7 years ago by Kitson Kelly <dojo@…>

In 43d05c64c43dfc9595c2e9455d83f4e9ee605037/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:10 Changed 7 years ago by Kitson Kelly <dojo@…>

In 585eba54389c9f612d73d8899be67090503efa36/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.