Opened 6 years ago

Closed 6 years ago

#17126 closed defect (fixed)

Reopen ymin ymax bug in dojox/charting/plot2d/common (Ticket #16531)

Reported by: superdweebie Owned by: cjolif
Priority: undecided Milestone: 1.10
Component: Charting Version: 1.9.0
Keywords: Cc:
Blocked By: Blocking:

Description

Ref: ​https://bugs.dojotoolkit.org/ticket/16531

Attached is the patch and a test.

Attachments (4)

common.js​ (7.4 KB) - added by superdweebie 6 years ago.
dojox/charting/plot2d/common.js
plot2d_Base.js​ (691 bytes) - added by superdweebie 6 years ago.
dojox/charting/tests/plot2d_base.js
charting.js​ (91 bytes) - added by superdweebie 6 years ago.
dojox/charting/tests/charting.js
17126.patch​ (1.2 KB) - added by cjolif 6 years ago.
slightly different version of the patch, having a single loop like for the non-index case

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by superdweebie

Attachment: common.js​ added

dojox/charting/plot2d/common.js

Changed 6 years ago by superdweebie

Attachment: plot2d_Base.js​ added

dojox/charting/tests/plot2d_base.js

Changed 6 years ago by superdweebie

Attachment: charting.js​ added

dojox/charting/tests/charting.js

comment:1 Changed 6 years ago by cjolif

Owner: changed from Eugene Lazutkin to cjolif
Status: new → assigned

Changed 6 years ago by cjolif

Attachment: 17126.patch​ added

slightly different version of the patch, having a single loop like for the non-index case

comment:2 Changed 6 years ago by cjolif

Milestone: tbd → 1.10

superdweebie, see a slightly different patch. If that works for you I'll commit that one.

comment:3 Changed 6 years ago by superdweebie

Looks good to me.

Ta.

comment:4 Changed 6 years ago by cjolif

Resolution: → fixed
Status: assigned → closed

In [31440]:

fixes #17126. Fix computation of xmin/xmax when ymin/ymax is present on indexed series. !strict

Note: See TracTickets for help on using tickets.