Changes between Initial Version and Version 1 of Ticket #17119


Ignore:
Timestamp:
May 9, 2013, 3:52:37 PM (8 years ago)
Author:
Douglas Hays
Comment:

I'm confused by the description. "primitive" by default is type=number and compare compares 2 numbers based on min and max. number.length is undefined. If a widget is using this for nonnumeric values, then there should be a specialized compare method that does the .length value-add.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17119

    • Property Status changed from new to closed
    • Property Resolution changed from to invalid
  • Ticket #17119 – Description

    initial v1  
    22When using RangeBoundTextBox as editor in sitepen dgrid, I noticed that the min/max range was not validated upon editing the value.
    33After enquiring I noticed that the rangeCheck method had a bug :
    4 it invokes compare(primitive,constraints.min) and compare(primitive,constraints.min) from _FormWidgetMixin.js as opposed to invoking compare(primitive.length,constraints.min) and compare(primitive.length,constraints.max).
     4it invokes compare(primitive,constraints.min) and compare(primitive,constraints.max) from _FormWidgetMixin.js as opposed to invoking compare(primitive.length,constraints.min) and compare(primitive.length,constraints.max).
    55Applying this fix solved my issue and editor started working as expected.
    66