Opened 7 years ago

Closed 6 years ago

#17116 closed defect (fixed)

/dojox/form/uploader don´t call onError on IFRAME

Reported by: eduardogf Owned by: Mike Wilcox
Priority: undecided Milestone: 1.9.3
Component: DojoX Uploader Version: 1.9.0
Keywords: Cc:
Blocked By: Blocking:

Description

On File dojox/form/uploader/_IFrame.js there is an incorret variable name on line cheking for error, so the OnError? is never called. In 1.8.3, the return variable was data and in 1.9.0 the return changed to result, but the test for error was not updated.

The Line:

  if(data["ERROR"] || data["error"]){

Have to BE:

  if(result["ERROR"] || result["error"]){

After the change the IFrame starts to work again in 1.9.0 as it should.

Bellow the Correct peace of code:

   request.post(url, {
      form: sendForm,
      handleAs: "json",
      content: data
    }).then(function(result){
      domConstruct.destroy(sendForm);
      if(result["ERROR"] || result["error"]){
         self.onError(result);
      }else{
         self.onComplete(result);
      }
    }, function(err){
      console.error('error parsing server result', err);
      domConstruct.destroy(sendForm);
      self.onError(err);
    });

Change History (4)

comment:1 Changed 6 years ago by eduardogf

After four months the release 1.9.1, contain the same error.

Another BUG #17402 was open by another user to release 1.9.1.

It´s just a single line to correct, but the problem persists in 1.9.1.

So again we have to correct the code to use DOJO upload with IFRAME

comment:2 Changed 6 years ago by dylans <dylan@…>

In 6169b5747e2e98d1f07f4ffc23ce6b1ee1a7238b/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:3 Changed 6 years ago by dylans <dylan@…>

In 209ef31746e962ae2d74625e3e3641adb6177433/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:4 Changed 6 years ago by dylan

Milestone: tbd1.9.3
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.