Opened 6 years ago

Closed 4 years ago

#17111 closed enhancement (fixed)

[patch] [cla] Disable Firebug Lite for Opera

Reported by: Thomas Bachem Owned by: dylan
Priority: undecided Milestone: 1.9.8
Component: Core Version: 1.9.0
Keywords: Cc:
Blocked By: Blocking:

Description

Currently, there are several checks for native consoles in firebug.js:

if(
	has("ff") ||                                           // Firefox has Firebug
	has("chrome") ||                                       // Chrome 3+ has a console
	has("safari") ||                                       // Safari 4 has a console
	isNewIE ||                                             // Has the new IE console
	window.firebug ||                                      // Testing for mozilla firebug lite
	(typeof console != "undefined" && console.firebug) ||  // The firebug console
	dojo.config.useCustomLogger ||                         // Allow custom loggers
	has("air")                                             // isDebug triggers AIRInsector, not Firebug
){

So we should add

	has("opera") ||                                        // Opera has a console

nowadays.

I got the impression that the whole Firebug Lite thing is deprecated, but when using the isDebug config setting with an unbuilt source (during development), there's no way to prevent Firebug Lite from loading. So we should at least not load it in browsers where it's just annoying.

Attachments (1)

DojoFirebugLiteOpera.patch (566 bytes) - added by Thomas Bachem 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Thomas Bachem

Attachment: DojoFirebugLiteOpera.patch added

comment:1 Changed 4 years ago by dylan

Component: GeneralCore

comment:2 Changed 4 years ago by dylan

Milestone: tbd1.11
Owner: set to dylan
Status: newassigned

comment:3 Changed 4 years ago by bill

Milestone: 1.111.9.8

Actually, this is already taken care of by #18727, specifically a299af37620e95cb85c39e248aa001c9e6b9d0eb.

comment:4 Changed 4 years ago by bill

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.