Opened 7 years ago
Closed 4 years ago
#17111 closed enhancement (fixed)
[patch] [cla] Disable Firebug Lite for Opera
Reported by: | Thomas Bachem | Owned by: | dylan |
---|---|---|---|
Priority: | undecided | Milestone: | 1.9.8 |
Component: | Core | Version: | 1.9.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Currently, there are several checks for native consoles in firebug.js
:
if( has("ff") || // Firefox has Firebug has("chrome") || // Chrome 3+ has a console has("safari") || // Safari 4 has a console isNewIE || // Has the new IE console window.firebug || // Testing for mozilla firebug lite (typeof console != "undefined" && console.firebug) || // The firebug console dojo.config.useCustomLogger || // Allow custom loggers has("air") // isDebug triggers AIRInsector, not Firebug ){
So we should add
has("opera") || // Opera has a console
nowadays.
I got the impression that the whole Firebug Lite thing is deprecated, but when using the isDebug
config setting with an unbuilt source (during development), there's no way to prevent Firebug Lite from loading. So we should at least not load it in browsers where it's just annoying.
Attachments (1)
Change History (5)
Changed 7 years ago by
Attachment: | DojoFirebugLiteOpera.patch added |
---|
comment:1 Changed 4 years ago by
Component: | General → Core |
---|
comment:2 Changed 4 years ago by
Milestone: | tbd → 1.11 |
---|---|
Owner: | set to dylan |
Status: | new → assigned |
comment:3 Changed 4 years ago by
Milestone: | 1.11 → 1.9.8 |
---|
comment:4 Changed 4 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Actually, this is already taken care of by #18727, specifically a299af37620e95cb85c39e248aa001c9e6b9d0eb.