Dialog: show()/hide() should return a deferred in every condition

[gorgoroth]

Currently Dialog::show() does not return a deferred if open class member is true. A similar problem is present in Dialog::hide() when the open class member is false. I think it is better to always return a resolved deferred in theese scenarios because a program could invoke Dialog::show().then() and if the dialog is already shown, no defferred/promise is returned and 'then' would fail.

[bill]

I thought I fixed that already but I guess not. OK, agreed.

[Bill Keese <bill@…>]

In 8cbe1a44b75e564bb9a0f4931bf6f26e0ac16b00/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[spaquette]

Test for Dialog show/hide not returning a promise in all cases

[spaquette]

Apologies, I was on the wrong bug when I clicked attach. That's what I get for not double-checking...

[bill]

OK... I tried your test case against the latest code. I don't see any exceptions in the console and this appears in the browser window:

Dialog is now shown for the first time.
value of Dialog.open: true
Second call to show after already shown; we should see this if show() is returning a promise.

Dialog is now hidden for the first time.
value of Dialog.open: false
Second call to hide after already hidden; we should see this if hide() is returning a promise.

Your test does fail against 1.9, which makes sense, since this ticket is marked as fixed in 1.10.

[bill]

#17779 is a duplicate of this ticket.