Opened 7 years ago

Closed 4 years ago

#17087 closed defect (patchwelcome)

dojox/layout/ResizeHandle does not work when a widget is placed in a popup window

Reported by: rjh Owned by:
Priority: undecided Milestone: 1.13
Component: DojoX Layout Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

I took a look at the code and it seems as if the ResizeHelper?'s location and mousedown and mouseup listeners are connected to windowBase so if a Floating Pane is placed in a popup window, then it won't resize correctly. The code segments I'm talking about are:

if(!this._resizeHelper){
     this._resizeHelper = new _ResizeHelper({
          id: 'dojoxGlobalResizeHelper'
     }).placeAt(windowBase.body());
     domClass.add(this._resizeHelper.domNode, this.activeResizeClass);
}

and

this._pconnects = [
     connect.connect(windowBase.doc,"onmousemove",this,"_updateSizing"),
     connect.connect(windowBase.doc,"onmouseup", this, "_endSizing")
];

I've found that if we replace windowBase.body() and windowBase.doc, with this.domNode.ownerDocument.body and this.domNode.ownerDocument respectively, then ResizeHandle? will work even when placed in a popup window because the location and mouse functions will now reference the document that ResizeHandle? is actually in as opposed to just placing it in windowBase which usually refers to the original document.

Change History (2)

comment:1 Changed 7 years ago by bill

Component: GeneralDojoX Layout

comment:2 Changed 4 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: newclosed

Given that no one has shown interest in creating a patch in the past 2+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.