Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#17076 closed defect (fixed)

[regression] dojox/form/Uploader sends name attribute as array always

Reported by: xMartin Owned by: Mike Wilcox
Priority: high Milestone: 1.9
Component: DojoX Uploader Version: 1.9.0rc2
Keywords: Cc: Colin Snover
Blocked By: Blocking:

Description

As of [15151] no matter if "multiple" is set to true or false the name attribute is sent as "XXXs[]". In Dojo 1.8 it was just "XXX" if "multiple" was set to false. This can break with existing servers.

I think we need a more flexible way to do this.

Change History (12)

comment:1 Changed 7 years ago by cjolif

You probably misreferenced the changeset, [15151] has nothing to do with that?

comment:2 Changed 7 years ago by xMartin

Yes, sorry. I meant #15151 and [30328].

comment:3 Changed 7 years ago by Adam Peller

Cc: Colin Snover added
Milestone: tbd1.9

Really ought to be documented for 1.9 or fixed for 1.9.x I'll let the release manager set the priority.

Last edited 7 years ago by Adam Peller (previous) (diff)

comment:4 Changed 7 years ago by Mike Wilcox

Resolution: invalid
Status: newclosed

I don't see the regression, and the docs confirm this is how it has been all along: http://dojotoolkit.org/reference-guide/1.8/dojox/form/Uploader.html#id15

The linked changeset is very large so if you are pointing to a specific piece of code, I can't find it.

Closing as invalid. If you can show me something more specific feel free to reopen.

comment:5 Changed 7 years ago by Colin Snover

The change in behaviour I am seeing between 1.8 and trunk is that in 1.8, Flash is used in IE, but in 1.9, iframe is used. I don’t see the issue the OP is reporting.

comment:6 Changed 7 years ago by xMartin

The change is in Uploader::_getFileFieldName. In 1.8 the "s[]" was only added if "multiple" was configured and "multiple" was supported. Now only the support is checked no matter if configured or not. My configuration is false for "multiple" but still "s[]" is added so the app breaks.

comment:7 Changed 7 years ago by Colin Snover

Resolution: invalid
Status: closedreopened

OK, my apologies, I do see that change you are describing as well. The reference guide is really unclear about what is supposed to happen in this case so I am happy to describe this as a regression.

comment:8 Changed 7 years ago by Colin Snover

Priority: undecidedhigh
Status: reopenedassigned

If you can get this done before the next RC then do so, but I will not block the release for a dojox bug.

comment:9 Changed 7 years ago by Mike Wilcox

Resolution: fixed
Status: assignedclosed

In [31370]:

Fixed HTML5 single upload regression Fixes #17076

comment:10 Changed 7 years ago by Mike Wilcox

The original error was in the PHP file, so I made the correction there and fixed the regression.

comment:11 Changed 7 years ago by Colin Snover

Why did the test file just get updated to force to html5?

comment:12 Changed 7 years ago by Mike Wilcox

What should it be?

Note: See TracTickets for help on using tickets.