Opened 7 years ago

Closed 7 years ago

#17071 closed defect (fixed)

gregorian.js cldr nls no longer has fields

Reported by: Pete Smith Owned by: bill
Priority: undecided Milestone: 1.9
Component: Internationalization Version: 1.9.0b2
Keywords: Cc: Douglas Hays, emmo@…, srl
Blocked By: Blocking:

Description

I was happily using the field- properties in the gregorian resource for things like:

"field-year": "Year"

And they are gone in the 1.9.0RC1.

http://bugs.dojotoolkit.org/changeset?old_path=%2Fdojo%2Fdojo%2Ftrunk%2Fcldr%2Fnls%2Fgregorian.js&old=31333&new_path=%2Fdojo%2Fdojo%2Ftrunk%2Fcldr%2Fnls%2Fgregorian.js&new=20000

Change History (13)

comment:1 Changed 7 years ago by Adam Peller

Cc: Douglas Hays added

It looks like the LDML schema changed, and the fields tag is now a peer of calendar, which makes sense. Unfortunately, it means fixing our xslt...

comment:2 Changed 7 years ago by Adam Peller

Cc: emmo@… added

comment:3 in reply to:  1 Changed 7 years ago by srl

Replying to peller:

It looks like the LDML schema changed, and the fields tag is now a peer of calendar, which makes sense. Unfortunately, it means fixing our xslt...

CLDR bug is CldrBug:5512 http://unicode.org/cldr/trac/ticket/5512 (you can add me to cc)

comment:4 Changed 7 years ago by Adam Peller

Cc: srl added

Thanks, srl. Also copying emmo to see if this data is included in the new JSON structure.

comment:5 Changed 7 years ago by bill

So previously in en.xml, <fields> was under the <calendars> / <calendar type=gregorian>. Now it's a sibling of <calendars>. Which I guess means that the fields apply to every calendar, not just the gregorian one.

The weird thing though is that we only have <fields> data for English, so it's useless for your app to pull this info out of the gregorian.js file. I.E. no matter what the user's language setting is, you are still going to get "Year" as the value of that field, so you might as well just hardcode it. Maybe there will be translations in a future version of CLDR.

Last edited 7 years ago by bill (previous) (diff)

comment:6 Changed 7 years ago by bill

Milestone: tbd1.9
Owner: changed from Adam Peller to bill
Status: newassigned

Actually, that last paragraph was wrong, I'm seeing field data in many languages.

Last edited 7 years ago by bill (previous) (diff)

comment:7 Changed 7 years ago by bill

In [31335]:

these files were apparently not checked in the last time CLDR data was generated, refs #17071 tangentially

comment:8 Changed 7 years ago by Adam Peller

Interesting. The $locale is an artifact of the loader (something generated at runtime, probably added since doug generated the output. see #15144) and probably shouldn't be in the script output. Shouldn't have any impact either way, so not that important. I guess we'd have to modify the script to exclude this particular property.

Last edited 7 years ago by Adam Peller (previous) (diff)

comment:9 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [31336]:

CLDR data changed so that <fields> is now a sibling of <calendars> rather than a child of <calendar>, but for backwards compatibility, associating the data in <fields> with each <calendar> when we output JSON files for the calendars. Unfortunately for some reason this changes the order of keys in some of the files. That shouldn't matter for JSON, but it makes the diff bigger than it really is.

Checkin split into multiple parts due to size.

Fixes #17071 !strict.

comment:10 Changed 7 years ago by bill

In [31337]:

Part 2 of 3: CLDR data changed so that <fields> is now a sibling of <calendars> rather than a child of <calendar>, but for backwards compatibility, associating the data in <fields> with each <calendar> when we output JSON files for the calendars. Unfortunately for some reason this changes the order of keys in some of the files. That shouldn't matter for JSON, but it makes the diff bigger than it really is.

Fixes #17071 !strict.

comment:11 Changed 7 years ago by bill

In [31338]:

Part 3 of 3: CLDR data changed so that <fields> is now a sibling of <calendars> rather than a child of <calendar>, but for backwards compatibility, associating the data in <fields> with each <calendar> when we output JSON files for the calendars. Unfortunately for some reason this changes the order of keys in some of the files. That shouldn't matter for JSON, but it makes the diff bigger than it really is.

Checking in remaining files split off from first checkin.)

Fixes #17071 !strict.

comment:12 Changed 7 years ago by Colin Snover

Resolution: fixed
Status: closedreopened

Builds are failing with missing locale errors.

error(354) Root bundle indicates localized bundles that don't exist. Root: dojo/cldr/nls/roc; missing bundles: 'ca'.
error(354) Root bundle indicates localized bundles that don't exist. Root: dojo/cldr/nls/indian; missing bundles: 'fr'.
error(354) Root bundle indicates localized bundles that don't exist. Root: dojo/cldr/nls/coptic; missing bundles: 'fr','ro'.
error(354) Root bundle indicates localized bundles that don't exist. Root: dojo/cldr/nls/ethiopic; missing bundles: 'fr','ro'.

Last edited 7 years ago by Colin Snover (previous) (diff)

comment:13 Changed 7 years ago by bill

Resolution: fixed
Status: reopenedclosed

In [31351]:

Part 4 of 3: new language files, containing just the field-* data. Fixes #17071 !strict.

Note: See TracTickets for help on using tickets.