Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#17070 closed defect (fixed)

GridContainerLite typeof check issue

Reported by: Brian Arnold Owned by: Brian Arnold
Priority: low Milestone: 1.9
Component: DojoX Layout Version: 1.9.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

In dojox/layout/GridContainerLite, there's a check that reads as follows:

typeof(p) === undefined

That undefined should really be "undefined", because that check is *always* going to be false, since typeof always returns a truthy string. Additionally, it's made to look like a function invocation, which it isn't. Going to be pushing a few updates to fix this across the board.

Change History (5)

comment:1 Changed 7 years ago by Brian Arnold

Resolution: fixed
Status: newclosed

In [31328]:

Updating typeof check, fixes #17070, !strict due to legacy side effect issues

comment:2 Changed 7 years ago by Brian Arnold

In [31329]:

Updating typeof check in 1.8 branch, refs #17070, !strict due to legacy side effect issues

comment:3 Changed 7 years ago by Brian Arnold

In [31330]:

Updating typeof check in 1.7 branch, refs #17070, !strict due to legacy side effect issues

comment:4 Changed 7 years ago by Brian Arnold

In [31331]:

Updating typeof check in 1.6 branch, refs #17070, !strict due to legacy side effect issues

comment:5 Changed 7 years ago by Brian Arnold

In [31332]:

Updating typeof check in 1.5 branch, refs #17070, !strict due to legacy side effect issues

Note: See TracTickets for help on using tickets.