Opened 6 years ago

Closed 6 years ago

#17069 closed defect (fixed)

[dojox/app] History.js does not publish topics, but HistoryHash.js does

Reported by: Paul Christopher Owned by: Ed Chatelain
Priority: undecided Milestone: 1.9.1
Component: DojoX App Version: 1.9.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

As already discussed on the mailing list http://dojo-toolkit.33424.n3.nabble.com/dojox-app-How-to-make-TabBar-s-syncWithViews-work-td3995986.html : History.js does not publish any topics. Widgets therefore cannot listen to the app and adapt their behavior. In contrast to History.js, HistoryHash.js does publish topics.

Attached patch adds publish/subscribe mechanisms to History.js. In the long run

  • dojox/app should additionally publish dojox/mobile conformant topics so that e.g. dojox/mobile/TabBar's syncWithViews works when used inside dojox/app.
  • HistoryHash and History should use the same topics (and not different ones)

Attachments (1)

History.js.diff (1.0 KB) - added by Paul Christopher 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by Paul Christopher

Attachment: History.js.diff added

comment:1 Changed 6 years ago by Ed Chatelain

I will try the patch, but it is too late to get it into 1.9, if it works I will try to get it into 1.9.1. But the good news is that these controllers are designed to be easily customizable, so if this patch works for you, your app can use setup a custom history controller in your config which uses a custom history controller with this fix.

comment:2 Changed 6 years ago by Ed Chatelain

Milestone: tbd1.9.1
Resolution: fixed
Status: newclosed

Fixed by https://github.com/dmachi/dojox_application/pull/198 Thanks Paul Christopher (CLA).

Note: See TracTickets for help on using tickets.