Changes between Initial Version and Version 1 of Ticket #17062, comment 5


Ignore:
Timestamp:
May 3, 2013, 7:17:27 PM (7 years ago)
Author:
Adrian Vasiliu
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17062, comment 5

    initial v1  
    11Welcome, glad to see that you take my comments as constructive criticism. Okay, let me first summarize where we are in my eyes:
    221. Initially (before my changes for #16363), our scrolling machinery was confused (broken) by the automatic browser scroll when a field gets focused.
    3 2. My changes avoided that, while allowing to navigate with !Next/Tab but curiously with  with !Prev/Shift-Tab it doesn't uncover the hidden fields. (Would be nice to understand why...)
     32. My changes avoided that, while allowing to navigate with !Next/Tab but curiously (and asymmetrically) with !Prev/Shift-Tab it doesn't uncover the hidden fields. (There is no scroll event in such cases - would be nice to understand why).
    443. Your proposed patch nicely repairs the regression that I introduced, while introducing other misbehaviors: ergonomical regression on iOS (as described in my previous comment - that I would consider non-fatal, but annoying to see a regression for something that used to work very well) and quite severe regression on some Android, at least Android 4.0.4/stock browser, details below). (Testing would anyway need to cover more platforms.)
    55