Changes between Version 1 and Version 2 of Ticket #17062, comment 6


Ignore:
Timestamp:
May 6, 2013, 9:47:08 AM (6 years ago)
Author:
Adrian Vasiliu
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17062, comment 6

    v1 v2  
    11I have tried to investigate whether the regression due to #16363 was there at the origin of this change and to understand what produces it. In practice this may not modify the picture radically, but the fact is that part of the regression for the prev-next navigation with the fix of #16363 wasn't there at the moment this fix was first attached, that is on 21 Nov. 2012 (the patch was firstly mentioned in #16363#comment:1 and was refreshed later), and it is a side-effect of changes elsewhere (in dojox/mobile/common, see below).
    22
    3 I've compared the behavior of the test case originally attached to #16363 (#16363/test_TextBox-in-ScrollableView.html) in 1.9 vs with a checkout of Dojo at rev. 29961 (15 nov. 2012), that is around the time point when the original patch was attached, on top of which I've put the change in scrollable.js which as committed 4 months later. The behavior differs depending on browsers, but on iPhone 5 iOS 6 the navigation with "prev" works at rev. 29961 and does not work with 1.9.
     3I've compared the behavior of the test case originally attached to #16363 (#16363/test_TextBox-in-ScrollableView.html) in 1.9 vs with a checkout of Dojo at rev. 29961 (15 nov. 2012), that is around the time point when the original patch was attached, on top of which I've put the change in scrollable.js which was committed 4 months later. The behavior differs depending on browsers, but on iPhone 5 iOS 6 the navigation with "prev" works at rev. 29961 and does not work with 1.9.
    44
    55I have searched for the change which made the difference. There are many "candidates", including the numerous changes in dijit's focus management for form widgets and the changes in dojo/window.scrollIntoView (called by dijit on focus events). But so far I've identified the change which matters as the one in dojox/mobile/common. More exactly: at rev. 29961 just as in 1.9, _ScrollableMixin calls sv.scrollIntoView on resizeAll topics, and the changes in common are such that there is no longer any resizeAll topic published when navigating with prev/next on the virtual keyboard.