Changes between Initial Version and Version 1 of Ticket #17062, comment 15


Ignore:
Timestamp:
May 17, 2013, 3:29:07 PM (6 years ago)
Author:
Adrian Vasiliu
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17062, comment 15

    initial v1  
    1 I know the testing is not yet finished, and there are further adaptations to be done for some platforms. I will redo a global testing campaign when it will ready. However, at this stage I would have two general comments:
     1I know the testing is not yet finished, and there are further adaptations to be done for some platforms. I will redo a global testing campaign when it will ready. However, at this stage I would have these general comments:
    22   * The patch modifies drastically the default scrollType for Android (before patch: topLeft mode for Android < 3, after patch: topLeft for Android < 4.1 for now, and might further change). Per se, this might be a good change, but I don't think it should be done inside such a big patch for a specific issue (the one in this ticket). Instead, it would be better to do it in a dedicated ticket, say "Improve scrolling behavior on Android 3+" - of course after testing that the change not only accommodates the current fix, but is good in general (in particular we should look at possible regressions in the context of #14633, where the scroll type has been set to topLeft on Android < 3, and this was said to fix input field "jumping" issues. (For sure many things changed since then, including the changes in the present patch; still, testing in various contexts with and without input fields is mandatory, and a fortiori if this is to be put in 1.9.1.)
    33