Opened 6 years ago

Closed 6 years ago

#17057 closed defect (fixed)

[dojox/app] History.back() should never use defaultTransition but stored transition only

Reported by: Paul Christopher Owned by: Ed Chatelain
Priority: undecided Milestone: 1.9.1
Component: DojoX App Version: 1.9.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

Alas, I have not fully understood the concept of a "defaultTransition" which can be set on app-level and view-level in the config.json file.

However if a user clicks on the browser's back button, the stored HTML5 popState event object should be always used to "reverse" the transition. At the moment, both "defaultTransition" on view-level and app-level overpower this event object. This causes strange effects, e.g. you change tabs in the multiSceneApp without any animation, but you get a flip animation when hitting the back button (since the defaultTransition is set on view-level).

The defaultTransition are IMO useful properties to decide on the correct transition before a view is shown for the first time. But if a view has been already shown, hiding it again with the back button should use always the reversed variant of the used transition. Only if there is no transition type in the event object, the defaults should be used.

Change History (4)

comment:1 Changed 6 years ago by Ed Chatelain

I agree that there seems to be a problem, I will see if I can come up with a safe solution.

comment:2 Changed 6 years ago by Paul Christopher

Ed, I have tried to find a solution for this, see my proposal for a patch at #17056.

comment:3 Changed 6 years ago by Ed Chatelain

I will try the patch, but it is too late to get it into 1.9, if it works I will try to get it into 1.9.1. But the good news is that these controllers are designed to be easily customizable, so if this patch works for you, your app can use setup a custom history controller in your config which uses a custom history controller with this fix.

comment:4 Changed 6 years ago by Ed Chatelain

Milestone: tbd1.9.1
Resolution: fixed
Status: newclosed

Fixed by https://github.com/dmachi/dojox_application/pull/198 Thanks Paul Christopher (CLA).

Note: See TracTickets for help on using tickets.