Opened 7 years ago

Closed 6 years ago

#17045 closed defect (fixed)

dijit/PopupMenuItem baseClass

Reported by: Martin Repta Owned by: bill
Priority: undecided Milestone: 1.10
Component: Dijit Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

dijit/PopupMenuItem should have custom baseClass defined, currently it has none.

patch file attached.

Attachments (1)

PopupMenuItem.patch​ (460 bytes) - added by Martin Repta 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Martin Repta

Attachment: PopupMenuItem.patch​ added

comment:1 Changed 7 years ago by bill

Milestone: tbd → 1.10

Well, presumably PopupMenuItem currently inherits its baseClass from MenuItem. Looks like your patch would *change* the baseclass from dijitMenuItem to dijitPopupMenuItem, which would probably break lots of things, but maybe we can add a dijitPopupMenuItem base class.

comment:2 Changed 6 years ago by bill

Strangely though CheckedMenuItem? resets the base class from dijitMenuItem to dijitCheckedMenuItem, which means that it too apparently isn't picking up rules like: 

.dijitMenuItemDisabled * {
	/* for a disabled menu item, just set it to mostly transparent */
	opacity:0.5;
	cursor:default;
}

Probably both of them should have a dual base class.

comment:3 Changed 6 years ago by Bill Keese <bill@…>

Resolution: → fixed
Status: new → closed

In 70c56bb518ca442f46ecd34a14aff8a373d5d565/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?
Note: See TracTickets for help on using tickets.