Opened 8 years ago
Closed 7 years ago
#17045 closed defect (fixed)
dijit/PopupMenuItem baseClass
| Reported by: | Martin Repta | Owned by: | bill |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.10 |
| Component: | Dijit | Version: | 1.8.3 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
dijit/PopupMenuItem should have custom baseClass defined, currently it has none.
patch file attached.
Attachments (1)
Change History (4)
Changed 8 years ago by
| Attachment: | PopupMenuItem.patch added |
|---|
comment:1 Changed 8 years ago by
| Milestone: | tbd → 1.10 |
|---|
comment:2 Changed 7 years ago by
Strangely though CheckedMenuItem? resets the base class from dijitMenuItem to dijitCheckedMenuItem, which means that it too apparently isn't picking up rules like:
.dijitMenuItemDisabled * {
/* for a disabled menu item, just set it to mostly transparent */
opacity:0.5;
cursor:default;
}
Probably both of them should have a dual base class.
comment:3 Changed 7 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Well, presumably PopupMenuItem currently inherits its baseClass from MenuItem. Looks like your patch would *change* the baseclass from dijitMenuItem to dijitPopupMenuItem, which would probably break lots of things, but maybe we can add a dijitPopupMenuItem base class.