Changes between Initial Version and Version 1 of Ticket #17040, comment 2
- Timestamp:
- Apr 18, 2013, 5:22:09 AM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #17040, comment 2
initial v1 1 I tried to do a cleaner (but slightly bigger) patch where the inheritance order doesn't matter, and also there's no issue with the order of operations in postCreate(), which as a lifecycle creation method should really call edthis.inherited() before doing it's own thing. The main part of the change was rolling back the [31124] change to _HasDropDown.1 I tried to do a cleaner (but slightly bigger) patch where the inheritance order doesn't matter, and also there's no issue with the order of operations in postCreate(), which as a lifecycle creation method should really call this.inherited() before doing it's own thing. The main part of the change was rolling back the [31124] change to _HasDropDown. 2 2 3 3 It led to a strange problem in test_Select.html where mouseup on the first Select automatically selected Tennessee. Turns out it was that the mouseup listener setup in _FormWidgetMixin::_onFocus() calls this.focus(), which (after my change) calls _KeyNavMixin::focus() rather than _FormWidgetMixin::focus(), which then calls focusFirstChidl(). This is because Select fragilely extends _KeyNavMixin even though !SelectMenu is the container of the items being navigated.