commonStacked chart unintentionally overrides global variable

[neville1355]

Some of our JS code uses google closures's advanced compilation which will rename functions to an unpredictable variable name.

In one specific case, the global variable "v" was chosen, which commonStacked.js unintentionally overrides.

in dojox/charting/plot2d/commonStacked.js

getValue: function(series, i, x){
	var value = null, j, z;
	for(j = 0; j <= i; ++j){
		for(z = 0; z < series[j].data.length; z++){
			v = series[j].data[z];
			if(v !== null){
				if(v.x == x){
					if(!value){
						value = {x: x};
					}
					if(v.y != null){
						if(value.y == null){
							value.y = 0;
						}
						value.y += v.y;
					}
					break;
				}else if(v.x > x){break;}
			}
		}
	}
	return value;
}

Notice that "v" is used but never initialized as a variable. This overrides the global variable if it's being used.

I believe the fix is as simple as adding "v" to the variable initialization near the start of the function.

[bill]

Fixed already in [29673] right?

[neville1355]

Looks like it, thanks!