Opened 6 years ago

Closed 4 years ago

#17025 closed task (patchwelcome)

Increase dojo mobile doh test coverage.

Reported by: Sebastien Brunot Owned by: Patrick Ruzand
Priority: undecided Milestone: 1.13
Component: DojoX Mobile Version: 1.9.0b2
Keywords: Cc: Adrian Vasiliu
Blocked By: Blocking:

Description

This is a placeholder task to submit patches that defines new doh tests for dojo mobile or update existing tests in order to increase the test coverage of the framework.

Attachments (1)

comboBox-tests.patch (10.1 KB) - added by Sebastien Brunot 6 years ago.
Add some more automated tests for ComboBox (IBM CCLA).

Download all attachments as: .zip

Change History (15)

comment:1 Changed 6 years ago by Sebastien Brunot

I've added a patch, comboBox-tests.patch, that add some more automated tests for ComboBox on trunk.

comment:2 Changed 6 years ago by Eric Durocher

Milestone: tbd1.9.1

comment:3 Changed 6 years ago by Adrian Vasiliu

@sbrunot, the test passes fine on my Chrome 26, FF 20 and IE9 (all on Win7), but it fails on IE10/Win7. The typical error:

  _AssertFailure: assertEqual() failed:
 	expected
		3
	but got
		5
 with hint: 
	The number of options is not the expected one for view2-comboBox3
Last edited 6 years ago by Adrian Vasiliu (previous) (diff)

comment:4 Changed 6 years ago by Adrian Vasiliu

Cc: Adrian Vasiliu added

comment:5 Changed 6 years ago by Sebastien Brunot

Thanks, I guess that's what happen when we have to wait for a GA before commiting tests ;) I'll have a look to see what the problem is and will fix the patch if the tests needs to be updated.

Changed 6 years ago by Sebastien Brunot

Attachment: comboBox-tests.patch added

Add some more automated tests for ComboBox (IBM CCLA).

comment:6 Changed 6 years ago by Sebastien Brunot

After reproducing, it appears that the combobox component is broken with the new WindowsPhone? test:

1) It is impossible to enter a value using the keyboard to filter the content of the combobox (that's why the test is failing)

2) When a value has been selected, it is impossible to change it

I'm attaching a new version of the patch so that the tests on IE10 are run using the iPhone theme instead of the native WindowsPhone theme.

Version 0, edited 6 years ago by Sebastien Brunot (next)

comment:6 Changed 6 years ago by Sebastien Brunot

After reproducing, it appears that the combobox component is broken with the new WindowsPhone theme:

1) It is impossible to enter a value using the keyboard to filter the content of the combobox (that's why the test is failing)

2) When a value has been selected, it is impossible to change it

I'm attaching a new version of the patch so that the tests on IE10 are run using the iPhone theme instead of the native WindowsPhone theme.

comment:7 Changed 6 years ago by Adrian Vasiliu

Thanks. Now the tests passes on IE10 too, on both Win7 and Win8. The issue of ComboBox (which is experimental) with Win theme (which is also experimental) will be handled separately.

comment:8 Changed 6 years ago by Adrian Vasiliu

In [31434]:

refs #17025. Add more automated tests for ComboBox? - thanks Sebastien Brunot (IBM, CCLA).

comment:9 Changed 6 years ago by Adrian Vasiliu

In [31435]:

refs #17025. Add more automated tests for ComboBox? - thanks Sebastien Brunot (IBM, CCLA).

comment:10 Changed 6 years ago by Patrick Ruzand

Owner: changed from Eric Durocher to Patrick Ruzand
Status: newassigned

comment:11 Changed 6 years ago by Patrick Ruzand

Milestone: 1.9.11.10

comment:12 Changed 6 years ago by Patrick Ruzand

Milestone: 1.10tbd

comment:13 Changed 4 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: assignedclosed

Given that no one has shown interest in creating a patch in the past 2+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.