Opened 9 years ago
Closed 7 years ago
#17025 closed task (patchwelcome)
Increase dojo mobile doh test coverage.
Reported by: | Sebastien Brunot | Owned by: | Patrick Ruzand |
---|---|---|---|
Priority: | undecided | Milestone: | 1.13 |
Component: | DojoX Mobile | Version: | 1.9.0b2 |
Keywords: | Cc: | Adrian Vasiliu | |
Blocked By: | Blocking: |
Description
This is a placeholder task to submit patches that defines new doh tests for dojo mobile or update existing tests in order to increase the test coverage of the framework.
Attachments (1)
Change History (15)
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
Milestone: | tbd → 1.9.1 |
---|
comment:3 Changed 9 years ago by
@sbrunot, the test passes fine on my Chrome 26, FF 20 and IE9 (all on Win7), but it fails on IE10/Win7. The typical error:
_AssertFailure: assertEqual() failed: expected 3 but got 5 with hint: The number of options is not the expected one for view2-comboBox3
comment:4 Changed 9 years ago by
Cc: | Adrian Vasiliu added |
---|
comment:5 Changed 9 years ago by
Thanks, I guess that's what happen when we have to wait for a GA before commiting tests ;) I'll have a look to see what the problem is and will fix the patch if the tests needs to be updated.
Changed 9 years ago by
Attachment: | comboBox-tests.patch added |
---|
Add some more automated tests for ComboBox (IBM CCLA).
comment:6 Changed 9 years ago by
After reproducing, it appears that the combobox component is broken with the new WindowsPhone theme:
1) It is impossible to enter a value using the keyboard to filter the content of the combobox (that's why the test is failing)
2) When a value has been selected, it is impossible to change it
I'm attaching a new version of the patch so that the tests on IE10 are run using the iPhone theme instead of the native WindowsPhone theme.
comment:6 Changed 9 years ago by
After reproducing, it appears that the combobox component is broken with the new WindowsPhone theme:
1) It is impossible to enter a value using the keyboard to filter the content of the combobox (that's why the test is failing)
2) When a value has been selected, it is impossible to change it
I'm attaching a new version of the patch so that the tests on IE10 are run using the iPhone theme instead of the native WindowsPhone theme.
comment:7 Changed 9 years ago by
Thanks. Now the tests passes on IE10 too, on both Win7 and Win8. The issue of ComboBox (which is experimental) with Win theme (which is also experimental) will be handled separately.
comment:10 Changed 9 years ago by
Owner: | changed from Eric Durocher to Patrick Ruzand |
---|---|
Status: | new → assigned |
comment:11 Changed 9 years ago by
Milestone: | 1.9.1 → 1.10 |
---|
comment:12 Changed 8 years ago by
Milestone: | 1.10 → tbd |
---|
comment:13 Changed 7 years ago by
Milestone: | tbd → 1.12 |
---|---|
Resolution: | → patchwelcome |
Status: | assigned → closed |
Given that no one has shown interest in creating a patch in the past 2+ years, I'm closing this as patchwelcome.
I've added a patch, comboBox-tests.patch, that add some more automated tests for ComboBox on trunk.