Opened 6 years ago

Closed 5 years ago

#17023 closed enhancement (fixed)

[patch] [cla] dojo/on multiple event support should allow extension events

Reported by: Christian Schröder Owned by: Kris Zyp
Priority: undecided Milestone: 1.10
Component: Events Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

dojo/on allows multiple events by using a comma separated list. This should also support using an array to allow the usage of extension events.

i see it should be done in on.parse (dojo/on.js:82)

Attachments (1)

array-of-events.patch (1.8 KB) - added by Kris Zyp 6 years ago.
patch to add this functionality

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by bill

Component: GeneralEvents
Description: modified (diff)
Owner: set to Kris Zyp

Changed 6 years ago by Kris Zyp

Attachment: array-of-events.patch added

patch to add this functionality

comment:2 Changed 6 years ago by Kris Zyp

Added a patch, so we can commit this next time trunk is open to enhancements.

comment:3 Changed 6 years ago by bill

Milestone: tbd1.10
Summary: dojo/on multiple event support should allow extension events[patch] [cla] dojo/on multiple event support should allow extension events

We'd need automated tests too, of course.

comment:4 in reply to:  3 Changed 6 years ago by Kris Zyp

Replying to bill:

We'd need automated tests too, of course.

I am not sure I understand. Are you saying we need to add robot tests in addition to the standard DOH tests?

comment:5 Changed 6 years ago by bill

I just meant standard DOH tests (for this new feature). I didn't think they were in the patch, but I see them now, so nevermind.

comment:6 Changed 5 years ago by Kris Zyp <kriszyp@…>

Resolution: fixed
Status: newclosed

In 87facf31bae5f88822006126740c0e70da25b50b/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 5 years ago by bill

Resolution: fixed
Status: closedreopened

Regression test fails on IE8 (and possibly other browsers too).

comment:8 Changed 5 years ago by Kris Zyp <kriszyp@…>

Resolution: fixed
Status: reopenedclosed

In 8f90d105e7848315d8f2b022f0a724c0ea009f54/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.