Opened 9 years ago
Closed 7 years ago
#17020 closed defect (fixed)
[patch] XHR over file:// fails for IE >=9
Reported by: | vita | Owned by: | dylan |
---|---|---|---|
Priority: | undecided | Milestone: | 1.8.11 |
Component: | IO | Version: | 1.8.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Attachments (4)
Change History (10)
Changed 9 years ago by
Attachment: | xhr.js.patch added |
---|
comment:1 Changed 9 years ago by
Summary: | IE XHR detection fails for IE>=9 → [patch] XHR over file:// fails for IE >=9 |
---|
comment:2 Changed 9 years ago by
First of all, is this needed? Developers should not be using the file protocol on newer browsers because of the restrictions put on XMLHttpRequest in those browsers. In fact, according to Rawld's comments on #17015, the file protocol doesn't work in IE9. Second, the addition of a browser sniff is completely unneeded: the first use is basically a duplicate of the has('activex')
check, and the second change should be using dojo-force-activex-xhr
test instead of using a sniff. Third, please submit patches in unified diff format (svn diff
and git diff
should output unified diff by default). I'm keeping this open for now, but will most likely close this as wontfix
because developers should not be using the file protocol in newer browsers even though it was supported in older browsers. I will also close this as wontfix
if #17015 is true and the file protocol will not work at all in IE9.
comment:3 Changed 9 years ago by
Our JS client is using both .. http and file protocol. It can run in offline mode. Why we should not be using the file protocol? Are we evil?
comment:4 Changed 9 years ago by
File protocol work in IE9 and above. Here are two patches and testing file, which demonstrate the functionality. I remove double sniffing of IE to. Sources base is version 1.9.0RC2.
comment:5 Changed 7 years ago by
Milestone: | tbd → 1.11 |
---|---|
Owner: | changed from Bryan Forbes to dylan |
Status: | new → assigned |
comment:6 Changed 7 years ago by
Milestone: | 1.11 → 1.8.11 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Fixed in master ( https://github.com/dojo/dojo/commit/e13a7758ec051db56150886e03ef9ba9b655a0ed ), backported to 1.10 ( https://github.com/dojo/dojo/commit/8ce1fd06bf065f3c439234f0c687f03b639589c6 ), 1.9 ( https://github.com/dojo/dojo/commit/8cf26f5da035c373124d0b4c0bc1656d77c68686 ), and 1.8 ( https://github.com/dojo/dojo/commit/890a02eeaa0aafd9b3adfce00a3810fbc213a39c ).
Sorry this took 3 years, better late than never...
patch from vita