[regression] require.undef is broken

[Martin Minka]

This code worked and doesn't in 1.9.0b2

name = 'dojo/colors';
require.undef(name);
require([name]);

Problem is that Dojo will create request: GET http://localhost/0

Reason is the latest change:

mix(module, {def:0, executed:0, injected:0, node:0, url:0});

Url is set to 0 and will not be re-created when request is made.

[bill]

Broken in [30927]. I've never heard of require.undef() before; I'm not sure that's a public API.

[Martin Minka]

It gives many interesting usages and I think it is public, because require.undef is mentioned here:

• ​http://requirejs.org/docs/api.html#undef
• http://dojotoolkit.org/reference-guide/1.8/loader/amd.html

[Rawld Gill]

In [31264]:

improved undef to not erase the computed url of a module (note that the url *is* recomputed during undef); fixes #17011; !strict

[Rawld Gill]

fwiw, the undef API originated in the backdraft loader years ago and was included in the dojo loader. It looks like requirejs is now supporting it as well. That said, there is no agreed standard API.

[31264] does not erase the module URL, which was being erased as of [30927]. Notice that undef does recompute the URL. This is important since it gives error recovery/testing machinery the opportunity to change the way a URL is computed before undefining a module...which could have the net effect of pointing a module to a different URL.

[mc007]

Hi, I am having a hard time to reload modules through the undef-api. The undef seems to work and the re-load (requirexide.widgets.SelectWidget?) also requested the module file but when using the module later on, it can't be found, saying : xide.widgets.SelectWidget? is not a constructor. Any ideas ? thank you!

[dylan]

I assume you would require it with a valid AMD mid (e.g. xide/widgets/SelectWidget) and not the legacy xide.widgets.SelectWidget? format that you said in your comment @mc007?

[mc007]

Ups, I really meant xide/widgets/SelectWidget too, just forgot to fix the dots. However, I discovered a mistake in my code and finally all works as expected, sorry that I did bother you.

thank you very much for the prompt response!