Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16993 closed defect (fixed)

[patch][ccla] Tree: clicking on invisible expando icon does not select tree item

Reported by: liucougar Owned by: bill
Priority: undecided Milestone: 1.9
Component: Dijit Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

open dijit/tests/tree/test_Tree.html expand africa in the first tree click in the area to the left of the icon for the Egypt item (the area is the invisible expando icon)

the row is not selected.

i think when expando icon is not visible, clicking on it should be treated the same as if the user clicked anywhere else in the item, which should select the Egypt item in this case

Attachments (1)

16993.patch (3.5 KB) - added by liucougar 7 years ago.
proposed patch with test case

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by bill

Component: GeneralDijit
Owner: set to bill
Summary: [patch][ccla] clicking on invisible expando icon does not select tree item[patch][ccla] Tree: clicking on invisible expando icon does not select tree item

The patch makes sense to me, since clicking farther to the left does select the row.. Ideally it would have a test case.

Changed 7 years ago by liucougar

Attachment: 16993.patch added

proposed patch with test case

comment:2 Changed 7 years ago by liucougar

uploaded a new patch with test coverage

comment:3 Changed 7 years ago by bill

Looks good to me.

comment:4 Changed 7 years ago by liucougar

Resolution: fixed
Status: newclosed

In [31226]:

fixes #16993: clicking on invisible expando icon should properly select tree item
!strict

comment:5 Changed 7 years ago by liucougar

Milestone: tbd1.9
Note: See TracTickets for help on using tickets.