Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16983 closed enhancement (fixed)

Allow FontChoice Editor plugin dropdowns to be styleable

Reported by: Nick Fenwick Owned by: bill
Priority: undecided Milestone: 1.9
Component: Editor Version: 1.9.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

The FontChoice? editor plugin currently doesn't put any CSS class name on its dropdown to allow you to style it. They're currently much wider than they tend to need to be, e.g. the 'size' one with plainText:true set is about twice as wide as any of the text in the dropdown.

Just as a proof of concept, I've overridden the FontSize? dropdown and am currently doing this in postCreate:

domClass.add(this.select.domNode, this.command);

This allows me to style it in CSS:

.fontSize.dijitComboBox {
  width: 10em;
}

Suggest a patch is made to the templateString to allow the 'class' to include this.command. Does the class name need to be more specific?

Attachments (1)

16983.patch (582 bytes) - added by Nick Fenwick 6 years ago.
Patch showing inclusion of 'class' attribute on dropdown.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by Nick Fenwick

Attachment: 16983.patch added

Patch showing inclusion of 'class' attribute on dropdown.

comment:1 Changed 6 years ago by bill

Milestone: tbd1.9
Owner: set to bill
Status: newassigned

OK sure, I think we want to have the name include "dijit" so it doesn't conflict with user CSS, but anyway I'll checkin something similar to your patch.

comment:2 Changed 6 years ago by bill

Resolution: fixed
Status: assignedclosed

In [31182]:

Add CSS classes for Editor ComboBox?'s, fixes #16983 !strict.

comment:3 Changed 6 years ago by mahays0 <mahays0@…>

In c600b2a55eca609706ee61ab250baef566171e49/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.