Changes between Initial Version and Version 2 of Ticket #16967


Ignore:
Timestamp:
Apr 4, 2013, 1:47:53 AM (8 years ago)
Author:
bill
Comment:

Agreed, but _onKeyDown() was already removed completely in [30029]. So this is no longer an issue.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16967

    • Property Status changed from new to closed
    • Property Resolution changed from to fixed
    • Property Component changed from General to Dijit
    • Property Summary changed from Tree class should define an overridable method for creating the keyHandlerMap to Tree: define an overridable method for creating the keyHandlerMap
    • Property Milestone changed from tbd to 1.9
    • Property Type changed from defect to enhancement
  • Ticket #16967 – Description

    initial v2  
    11This is not a bug but a refactoring request. Consider this code:
    22
     3{{{
    34var map = this._keyHandlerMap;
    45                        if(!map){
     
    2021                                this._keyHandlerMap = map;
    2122                        }
     23}}}
    2224
    2325In order for derived Tree classes to add to the _keyHandlerMap, we must override the entire method _onKeyDown. Instead the map should be created by a factory method and we should be allowed to override this factory method (calling the inherited factory method to populate existing key presses).