Opened 7 years ago

Closed 7 years ago

#16964 closed task (fixed)

errors in test_validate.html?mode=test

Reported by: bill Owned by: Douglas Hays
Priority: blocker Milestone: 1.9
Component: Dijit - Form Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

[29878] had some mistaken test code like:

doh.t(true, this.textbox.isValid(false), 'nonfocused is valid');

rather than:

doh.t(this.textbox.isValid(false), 'nonfocused is valid');

But when I fix the test code, the test starts to get failures.

Change History (11)

comment:1 Changed 7 years ago by bill

In [31117]:

fix errors in test file, but commenting out failing tests until #16964 is fixed, refs #16964

comment:2 Changed 7 years ago by bill

Besides those two lines I commented out, the test is getting a failure on IE10 (Windows 8 desktop) that I don't know how to fix.

Last edited 7 years ago by bill (previous) (diff)

comment:3 Changed 7 years ago by Douglas Hays

Owner: changed from Douglas Hays to bill
Status: newassigned

These failures started with [30957]. _onBlur isn't firing on a DOM node native focus() call but does fire on a dijit focus() call.

comment:4 Changed 7 years ago by bill

Owner: changed from bill to Douglas Hays

The problem I listed in the ticket description, which happens on all browsers, was there from the beginning. If you rollback the code to [29878] and fix the errors in the test file, you get a failure when running the test.

I'll look at the IE10 problem from [30957] though.

Last edited 7 years ago by bill (previous) (diff)

comment:5 Changed 7 years ago by bill

In [31145]:

allow for IE9+ async focus in test_validate.html, refs #16926, #16964

comment:6 Changed 7 years ago by Douglas Hays

Milestone: tbd1.9

comment:7 Changed 7 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

In [31151]:

Fixes #16964. isValid did not understand editOptions from NumberTextBox?

comment:8 Changed 7 years ago by bill

Resolution: fixed
Status: closedreopened

After this change I'm getting failures in robot/ValidationTextBox on IE8, aren't you?

comment:9 Changed 7 years ago by Douglas Hays

Resolution: fixed
Status: reopenedclosed

In [31247]:

Fixes #16964. Change NumberTextBox?'s pattern method to understand editOptions, which is used by both isValid() via validator() and CurrencyTextBox? via inheritance.

comment:10 Changed 7 years ago by bill

Priority: undecidedblocker
Resolution: fixed
Status: closedreopened

validationMessages.html is also broken from you [31151] check in, and not fixed from your [31247].

comment:11 Changed 7 years ago by Douglas Hays

Resolution: fixed
Status: reopenedclosed

In [31265]:

Fixes #16964. "12." can now be marked as valid after being parsed by dojo/number when editOptions:{pattern:"#.#####"} is mixed into the constraints:{fractional:[true,false]} during editing.

Note: See TracTickets for help on using tickets.