Opened 7 years ago

Closed 4 years ago

#16950 closed defect (patchwelcome)

dojox/app: Templates not included in layer file

Reported by: Paul Christopher Owned by: Ed Chatelain
Priority: undecided Milestone: 1.13
Component: DojoX App Version: 1.9.0b1
Keywords: Cc: cjolif
Blocked By: Blocking:

Description

As already discussed on the mailing list (see http://dojo-toolkit.33424.n3.nabble.com/dojox-app-Cannot-build-application-tp3995252.html), at the moment all the template files seem to be not included in the layer file of a built application.

At least the network panel shows, that all those files are loaded by separate requests (although dojox/app/build/discoverAppConfig.js adds them to the layer)?

The build tool throws errors about the template files, too;

error(303) Missing include module for layer. missing: custom/scenes/multiSceneApp/basicPageLayout.html; layer: custom/layerMultiSceneApp
error(303) Missing include module for layer. missing: custom/scenes/multiSceneApp/scene1/view.html; layer: custom/layerMultiSceneApp
error(303) Missing include module for layer. missing: custom/scenes/multiSceneApp/homeScene/view.html; layer: custom/layerMultiSceneApp

Change History (7)

comment:1 Changed 7 years ago by cjolif

Cc: cjolif added

comment:2 Changed 6 years ago by Paul Christopher

As a workaround, I tried to include the template in the view's dependencies. Sadly this does not make a difference. Any chance to get this fixed for 1.9?

comment:3 Changed 6 years ago by cjolif

There is dojo standard build limitation that is causing this issue. I don't think it is fixed in 1.9. dojox/app can't do anything without that being fixed. That said template are usually not that big so it should not be that of an issue. That said it would be good if that could be fixed for 1.9.1.

comment:4 Changed 5 years ago by darb1353

This was 2 years ago. Has this been fixed? Was it fixed in 1.9.1? I don't see it in the milestone tickets that were fixed. I'm running into the exact same issue and can't seem to solve the problem. Is there anyway you could point to me a fix or work around? If not, is there anyway you can point me to where the issue is in the dojo standard so I can just fix it myself?

comment:5 Changed 5 years ago by Ed Chatelain

If you use dojo/text! to load the template, it should be included in the build. You could either add the dojo/text! for the template in each controller, or create a separate file with dojo/text! for each of the templates in one file which you would then add to your dependencies.

comment:6 in reply to:  5 Changed 5 years ago by darb1353

Alright, Thanks!

Replying to edchat:

If you use dojo/text! to load the template, it should be included in the build. You could either add the dojo/text! for the template in each controller, or create a separate file with dojo/text! for each of the templates in one file which you would then add to your dependencies.

comment:7 Changed 4 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: newclosed

Given the lack of attention to this ticket, we would accept a pull request. Closing as patchwelcome.

Note: See TracTickets for help on using tickets.