[regression] _this.domNode undefined in : dojox/mobile/scrollable.js

[mc007ibi]

I discovered this by switching from stable 1.8 to trunk. Its crashing in line 208 :

win.global.addEventListener("scroll", function(e){

if(_this.domNode.style.display === 'none'){ return; }

Please a simple sanity check there. Thank you.

[Adrian Vasiliu]

The piece of code your refer to is from scrollable's init() method, which documentation states "At least domNode and containerNode have to be given.". Also, before the line of code you refer to, there are a couple of other "unprotected" usages of this.domNode inside this init(). Hence, to be sure we do the right fix, it would be helpful if you could provide information about the way you use scrollable.js, ideally a test case allowing to reproduce.

[Adrian Vasiliu]

@mc007ibi, we are still waiting for information about how to reproduce.

[Adrian Vasiliu]

In the meantime a case when this hurts has been found: dojox/mobile/tests/test_StoreCarousel-resize.html with the following scenario:

launch for instance on iPad, select the last item of the carousel, then change the orientation (landscape/portrait).

The attached patch fixes it by adding the "sanity check" plus the removal of the listener in scrollable.cleanup() (which is called by _ScrollableMixin.destroy()).

[Adrian Vasiliu]

Fixes regression in some cases of DOM destruction - Adrian Vasiliu (IBM, CCLA)

[Eric Durocher]

In [31334]:

fixes #16948, refs #16363. Fix regression caused by "scroll" listener added to fix #16363, and which was not removed on view destroys. Thanks Adrian Vasiliu (IBM, CCLA). !strict