[patch] InlineEditBox with dijit/form/TextBox does not mask password

[Eric Martin]

The dijit/form/TextBox masks the password normally, but the password is not masked when the inline text is displayed -- ie, the plain text is shown. I have looked at #4264 and added the suggested editorParams:{'password'} tot he data-dojo-props but this does not resolve the issue. See attached html file.

[Eric Martin]

I also tried using an input type="password" as the base element for the InlineEditBox? but the input value is unchanged by "save". If _setValueAttr in dijit/InlineEditBox.js were modified by adding the following line above line 597,

   this.displayNode.value = renderVal || "";

this would allow the input tag to be used with InlineEditBox?.

[bill]

This isn't expected to work since the InlineEditBox doesn't have any provisions for displaying anything other than the plain-text version of the value of the edit widget. Not sure if we'd want to implement this enhancement. Doug, what do you think?

[overtune]

I think this feature would be really usefull. I have implemented it by changing line 608 of InlineEditBox?.js. From:

this.displayNode.innerHTML = renderVal || this.noValueIndicator;

To:

if (this.editorParams && this.editorParams.type === 'password') {
    this.displayNode.innerHTML = "********";
} else {
    this.displayNode.innerHTML = renderVal || this.noValueIndicator;
}

It's quite a simple solution that perhaps needs a bit more thinking. But I think something like this would work better than just displaying the password in plain text.

[dylan]

It does seem like a very simple solution if it doesn't introduce other problems. That said, my guess is that Bill won't want to add this for 1.x.

Bill, please review the very short patch and see if it's really that simple. If not, let's just close as won't fix for 1.x.

[dylan]

Bill, should I create a PR for this, or are you interested in handling this one?

[dylan]

PR added at ​https://github.com/dojo/dijit/pull/108 based on notes in this ticket.

[dylan]

Moving to 1.12.

[dylan]

Ticket planning... move current 1.12 tickets out to 1.13 that likely won't get fixed in 1.12.

[Michael Van Sickle <mvansickle@…>]

In 6435648/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Michael Van Sickle <mvansickle@…>]

In ab21528/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Michael Van Sickle <mvansickle@…>]

In b46316a/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Michael Van Sickle <mvansickle@…>]

In 11d5f99/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Michael Van Sickle <mvansickle@…>]

In c86ec5d/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?