#16942 closed enhancement (fixed)
[patch] InlineEditBox with dijit/form/TextBox does not mask password
| Reported by: | Eric Martin | Owned by: | bill |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.8.13 |
| Component: | Dijit | Version: | 1.8.3 |
| Keywords: | Cc: | Douglas Hays | |
| Blocked By: | Blocking: |
Description
The dijit/form/TextBox masks the password normally, but the password is not masked when the inline text is displayed -- ie, the plain text is shown. I have looked at #4264 and added the suggested editorParams:{'password'} tot he data-dojo-props but this does not resolve the issue. See attached html file.
Attachments (1)
Change History (16)
Changed 9 years ago by
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
| Cc: | Douglas Hays added |
|---|---|
| Type: | defect → enhancement |
This isn't expected to work since the InlineEditBox doesn't have any provisions for displaying anything other than the plain-text version of the value of the edit widget. Not sure if we'd want to implement this enhancement. Doug, what do you think?
comment:3 Changed 7 years ago by
I think this feature would be really usefull. I have implemented it by changing line 608 of InlineEditBox?.js. From:
this.displayNode.innerHTML = renderVal || this.noValueIndicator;
To:
if (this.editorParams && this.editorParams.type === 'password') {
this.displayNode.innerHTML = "********";
} else {
this.displayNode.innerHTML = renderVal || this.noValueIndicator;
}
It's quite a simple solution that perhaps needs a bit more thinking. But I think something like this would work better than just displaying the password in plain text.
comment:4 Changed 6 years ago by
| Milestone: | tbd → 1.11 |
|---|
It does seem like a very simple solution if it doesn't introduce other problems. That said, my guess is that Bill won't want to add this for 1.x.
Bill, please review the very short patch and see if it's really that simple. If not, let's just close as won't fix for 1.x.
comment:5 Changed 6 years ago by
| Summary: | InlineEditBox with dijit/form/TextBox does not mask password → [patch] InlineEditBox with dijit/form/TextBox does not mask password |
|---|
comment:6 Changed 6 years ago by
Bill, should I create a PR for this, or are you interested in handling this one?
comment:7 Changed 6 years ago by
PR added at https://github.com/dojo/dijit/pull/108 based on notes in this ticket.
comment:9 Changed 5 years ago by
| Milestone: | 1.12 → 1.13 |
|---|
Ticket planning... move current 1.12 tickets out to 1.13 that likely won't get fixed in 1.12.
comment:15 Changed 5 years ago by
| Milestone: | 1.13 → 1.8.13 |
|---|
I also tried using an input type="password" as the base element for the InlineEditBox? but the input value is unchanged by "save". If _setValueAttr in dijit/InlineEditBox.js were modified by adding the following line above line 597,
this would allow the input tag to be used with InlineEditBox?.